From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 08AEC6917D for ; Thu, 12 Nov 2020 16:26:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 070C812643 for ; Thu, 12 Nov 2020 16:26:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 017EA12625 for ; Thu, 12 Nov 2020 16:26:05 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BDC494252F for ; Thu, 12 Nov 2020 16:26:04 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Thu, 12 Nov 2020 16:26:01 +0100 Message-Id: <20201112152603.8106-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201112152603.8106-1-d.csapak@proxmox.com> References: <20201112152603.8106-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.369 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [content.pm, pbsplugin.pm] Subject: [pve-devel] [PATCH storage 1/2] api2/storage/content: add comment and verification fields to content listing X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Nov 2020 15:26:09 -0000 for now only for pbs, since we do not have such infos elsewhere Signed-off-by: Dominik Csapak --- PVE/API2/Storage/Content.pm | 20 ++++++++++++++++++++ PVE/Storage/PBSPlugin.pm | 3 +++ 2 files changed, 23 insertions(+) diff --git a/PVE/API2/Storage/Content.pm b/PVE/API2/Storage/Content.pm index f2e3e57..8d2ff32 100644 --- a/PVE/API2/Storage/Content.pm +++ b/PVE/API2/Storage/Content.pm @@ -87,6 +87,26 @@ __PACKAGE__->register_method ({ minimum => 0, optional => 1, }, + comment => { + description => "An optional Comment.", + type => 'string', + optional => 1, + }, + verification => { + description => "Last backup verification result, only useful for PBS storages.", + type => 'object', + properties => { + state => { + description => "Last backup verification state.", + type => 'string', + }, + upid => { + description => "Last backup verification UPID.", + type => 'string', + }, + }, + optional => 1, + }, }, }, links => [ { rel => 'child', href => "{volid}" } ], diff --git a/PVE/Storage/PBSPlugin.pm b/PVE/Storage/PBSPlugin.pm index 6403e2e..28f6a3b 100644 --- a/PVE/Storage/PBSPlugin.pm +++ b/PVE/Storage/PBSPlugin.pm @@ -523,6 +523,9 @@ sub list_volumes { ctime => $epoch, }; + $info->{verification} = $item->{verification} if defined($item->{verification}); + $info->{comment} = $item->{comment} if defined($item->{comment}); + push @$res, $info; } -- 2.20.1