From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 52B21667CC for ; Fri, 6 Nov 2020 15:31:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4F160232C0 for ; Fri, 6 Nov 2020 15:31:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5A7B3232A8 for ; Fri, 6 Nov 2020 15:31:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1F1C84605B for ; Fri, 6 Nov 2020 15:31:07 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Fri, 6 Nov 2020 15:30:59 +0100 Message-Id: <20201106143059.22047-5-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201106143059.22047-1-f.ebner@proxmox.com> References: <20201106143059.22047-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.028 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemumigrate.pm] Subject: [pve-devel] [RFC v2 qemu-server 5/5] deactivate volumes after storage_migrate X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Nov 2020 14:31:38 -0000 Signed-off-by: Fabian Ebner --- same comment as for the corresponding LXC patch PVE/QemuMigrate.pm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm index f2c2b07..10cf31a 100644 --- a/PVE/QemuMigrate.pm +++ b/PVE/QemuMigrate.pm @@ -569,6 +569,11 @@ sub sync_disks { $self->{volume_map}->{$volid} = $new_volid; $self->log('info', "volume '$volid' is '$new_volid' on the target\n"); + + eval { PVE::Storage::deactivate_volumes($storecfg, [$volid]); }; + if (my $err = $@) { + $self->log('warn', $err); + } } } }; -- 2.20.1