From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6694C667BD for ; Fri, 6 Nov 2020 15:31:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4FD20232DD for ; Fri, 6 Nov 2020 15:31:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 57B09232A7 for ; Fri, 6 Nov 2020 15:31:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1ACED46031 for ; Fri, 6 Nov 2020 15:31:07 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Fri, 6 Nov 2020 15:30:57 +0100 Message-Id: <20201106143059.22047-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201106143059.22047-1-f.ebner@proxmox.com> References: <20201106143059.22047-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.028 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [migrate.pm] Subject: [pve-devel] [RFC v2 container 3/5] deactivate volumes after storage_migrate X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Nov 2020 14:31:09 -0000 Signed-off-by: Fabian Ebner --- This is probably not worth it, for two reasons: 1. only local unused volumes are not already deactivated by the existing code 2. if nothing else goes wrong, the volumes migrated with storage_migrate will be deleted anyways src/PVE/LXC/Migrate.pm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm index 94a78c5..7c3536f 100644 --- a/src/PVE/LXC/Migrate.pm +++ b/src/PVE/LXC/Migrate.pm @@ -294,6 +294,11 @@ sub phase1 { if (my $err = $@) { die "storage migration for '$volid' to storage '$sid' failed - $err\n"; } + + eval { PVE::Storage::deactivate_volumes($self->{storecfg}, [$volid]); }; + if (my $err = $@) { + $self->log('warn', $err); + } } my $conffile = PVE::LXC::Config->config_file($vmid); -- 2.20.1