From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 573EC667B3 for ; Fri, 6 Nov 2020 15:31:08 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4DD0C232BF for ; Fri, 6 Nov 2020 15:31:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 44F7B23296 for ; Fri, 6 Nov 2020 15:31:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0E71A4604F for ; Fri, 6 Nov 2020 15:31:07 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Fri, 6 Nov 2020 15:30:55 +0100 Message-Id: <20201106143059.22047-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.028 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [storage.pm] Subject: [pve-devel] [PATCH v2 storage 1/5] fix #3030: always activate volumes in storage_migrate X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Nov 2020 14:31:08 -0000 AFAICT the snapshot activation is not necessary for our plugins at the moment, but it doesn't really hurt and might be relevant in the future or for external plugins. Deactivating volumes is up to the caller, because for example, for replication on a running guest, we obviously don't want to deactivate volumes. Suggested-by: Fabian Grünbichler Signed-off-by: Fabian Ebner --- PVE/Storage.pm | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/PVE/Storage.pm b/PVE/Storage.pm index cd7b5ff..69c373b 100755 --- a/PVE/Storage.pm +++ b/PVE/Storage.pm @@ -697,6 +697,13 @@ sub storage_migrate { }; volume_snapshot($cfg, $volid, $snapshot) if $migration_snapshot; + + if (defined($snapshot)) { + activate_volumes($cfg, [$volid], $snapshot); + } else { + activate_volumes($cfg, [$volid]); + } + eval { if ($insecure) { my $input = IO::File->new(); -- 2.20.1