From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5995366737 for ; Fri, 6 Nov 2020 15:20:20 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 57E0E2273E for ; Fri, 6 Nov 2020 15:20:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0182622719 for ; Fri, 6 Nov 2020 15:20:19 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BE9AC4604F for ; Fri, 6 Nov 2020 15:20:18 +0100 (CET) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Fri, 6 Nov 2020 15:19:41 +0100 Message-Id: <20201106141942.7643-4-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201106141942.7643-1-s.ivanov@proxmox.com> References: <20201106141942.7643-1-s.ivanov@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.090 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [config.pm] Subject: [pve-devel] [PATCH container v3 1/2] add fsfreeze helper: X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Nov 2020 14:20:20 -0000 fsfreeze_mountpoint issues the same ioctls as fsfreeze(8) on the provided directory (the $thaw parameter deciding between '--freeze' and '--unfreeze') This is used for container backups on RBD, where snapshots on containers, which are heavy on IO, are not mountable readonly, because the ext4 is not consistent. Needed to fix #2991 and #2528. The ioctl numbers were found via strace -X verbose (and verified with the kernel documentation). Signed-off-by: Stoiko Ivanov --- src/PVE/LXC/Config.pm | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm index 49f599b..0528d51 100644 --- a/src/PVE/LXC/Config.pm +++ b/src/PVE/LXC/Config.pm @@ -13,6 +13,9 @@ use PVE::Tools; use base qw(PVE::AbstractConfig); +use constant {FIFREEZE => 0xc0045877, + FITHAW => 0xc0045878}; + my $nodename = PVE::INotify::nodename(); my $lock_handles = {}; my $lockdir = "/run/lock/lxc"; @@ -109,6 +112,22 @@ sub __snapshot_check_freeze_needed { return ($ret, $ret); } +# implements similar functionality to fsfreeze(8) +sub fsfreeze_mountpoint { + my ($path, $thaw) = @_; + + my $op = $thaw ? 'thaw' : 'freeze'; + my $ioctl = $thaw ? FITHAW : FIFREEZE; + + sysopen my $fd, $path, O_RDONLY or die "failed to open $path: $!\n"; + my $ioctl_err; + if (!ioctl($fd, $ioctl, 0)) { + $ioctl_err = "$!"; + } + close($fd); + die "fs$op '$path' failed - $ioctl_err\n" if defined $ioctl_err; +} + sub __snapshot_freeze { my ($class, $vmid, $unfreeze) = @_; -- 2.20.1