From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9D66F647A3 for ; Fri, 30 Oct 2020 13:48:45 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 92025139CE for ; Fri, 30 Oct 2020 13:48:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 48B31139BB for ; Fri, 30 Oct 2020 13:48:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 105CB45F78 for ; Fri, 30 Oct 2020 13:48:39 +0100 (CET) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Fri, 30 Oct 2020 13:48:37 +0100 Message-Id: <20201030124838.23655-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.010 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] ui: fix column behavior with browser scaling X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2020 12:48:45 -0000 especially on chromium based browser (e.g. chrome, edge) it can happen, depending on the zoom level, that the last column does not fit next to the other columns and is moved below the other columns. This results in an ugly looking UI and in the worst case makes it unusable. This can also be triggered if the monitor is set to a higher scaling / different DPI settings. I was able to have the same problem in Edge when setting the scaling in the windows display settings to 125%. Setting the column width to a little bit less than 0.5 avoids this problem. Signed-off-by: Aaron Lauterer --- www/manager6/window/Clone.js | 4 ++-- www/manager6/window/Migrate.js | 4 ++-- www/manager6/window/Settings.js | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/www/manager6/window/Clone.js b/www/manager6/window/Clone.js index 5c6c2f75..836a3025 100644 --- a/www/manager6/window/Clone.js +++ b/www/manager6/window/Clone.js @@ -265,13 +265,13 @@ Ext.define('PVE.window.Clone', { }, items: [ { - columnWidth: 0.5, + columnWidth: 0.495, padding: '0 10 0 0', layout: 'anchor', items: col1 }, { - columnWidth: 0.5, + columnWidth: 0.495, padding: '0 0 0 10', layout: 'anchor', items: col2 diff --git a/www/manager6/window/Migrate.js b/www/manager6/window/Migrate.js index 3096dd1a..8ac1a173 100644 --- a/www/manager6/window/Migrate.js +++ b/www/manager6/window/Migrate.js @@ -314,7 +314,7 @@ Ext.define('PVE.window.Migrate', { items: [ { xtype: 'container', - columnWidth: 0.5, + columnWidth: 0.495, items: [{ xtype: 'displayfield', name: 'source', @@ -334,7 +334,7 @@ Ext.define('PVE.window.Migrate', { }, { xtype: 'container', - columnWidth: 0.5, + columnWidth: 0.495, items: [{ xtype: 'pveNodeSelector', reference: 'pveNodeSelector', diff --git a/www/manager6/window/Settings.js b/www/manager6/window/Settings.js index e3519b1f..ab40af6f 100644 --- a/www/manager6/window/Settings.js +++ b/www/manager6/window/Settings.js @@ -185,7 +185,7 @@ Ext.define('PVE.window.Settings', { items: [{ xtype: 'fieldset', - columnWidth: 0.5, + columnWidth: 0.495, title: gettext('Webinterface Settings'), margin: '5', layout: { @@ -311,7 +311,7 @@ Ext.define('PVE.window.Settings', { { xtype: 'container', layout: 'vbox', - columnWidth: 0.5, + columnWidth: 0.495, margin: '5', defaults: { width: '100%', -- 2.20.1