From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3DB2363FF3 for ; Thu, 29 Oct 2020 14:31:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0FE969D13 for ; Thu, 29 Oct 2020 14:31:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 29CA69CD8 for ; Thu, 29 Oct 2020 14:31:38 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D72FC45F9B for ; Thu, 29 Oct 2020 14:31:37 +0100 (CET) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Thu, 29 Oct 2020 14:31:28 +0100 Message-Id: <20201029133132.28100-5-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201029133132.28100-1-f.ebner@proxmox.com> References: <20201029133132.28100-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.032 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [replicationconfig.pm] Subject: [pve-devel] [PATCH v2 guest-common 4/8] create nolock variant for switch_replication_job_target X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2020 13:31:39 -0000 so that it can be used within job_status Signed-off-by: Fabian Ebner --- Changes from v1: * this was part of the following patch PVE/ReplicationConfig.pm | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/PVE/ReplicationConfig.pm b/PVE/ReplicationConfig.pm index 9dfb9da..6ba87ae 100644 --- a/PVE/ReplicationConfig.pm +++ b/PVE/ReplicationConfig.pm @@ -230,21 +230,26 @@ sub find_local_replication_job { # makes old_target the new source for all local jobs of this guest # makes new_target the target for the single local job with target old_target +sub switch_replication_job_target_nolock { + my ($cfg, $vmid, $old_target, $new_target) = @_; + + foreach my $jobcfg (values %{$cfg->{ids}}) { + next if $jobcfg->{guest} ne $vmid; + next if $jobcfg->{type} ne 'local'; + + $jobcfg->{target} = $new_target if $jobcfg->{target} eq $old_target; + $jobcfg->{source} = $old_target; + } + $cfg->write(); +} + sub switch_replication_job_target { my ($vmid, $old_target, $new_target) = @_; my $update_jobs = sub { my $cfg = PVE::ReplicationConfig->new(); - foreach my $jobcfg (values %{$cfg->{ids}}) { - next if $jobcfg->{guest} ne $vmid; - next if $jobcfg->{type} ne 'local'; - - $jobcfg->{target} = $new_target if $jobcfg->{target} eq $old_target; - $jobcfg->{source} = $old_target; - } - $cfg->write(); + $cfg->switch_replication_job_target_nolock($vmid, $old_target, $new_target); }; - lock($update_jobs); } -- 2.20.1