From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A600564059 for ; Thu, 29 Oct 2020 14:11:31 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 769DD9589 for ; Thu, 29 Oct 2020 14:11:01 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 27FD79547 for ; Thu, 29 Oct 2020 14:10:44 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DB1FC45F98 for ; Thu, 29 Oct 2020 14:10:43 +0100 (CET) From: Stefan Reiter To: pve-devel@lists.proxmox.com Date: Thu, 29 Oct 2020 14:10:30 +0100 Message-Id: <20201029131036.11786-1-s.reiter@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.038 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v2 0/6] QEMU backup cancellation fixes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2020 13:11:31 -0000 Some bugfixes for qmp_backup_cancel and create_backup_jobs, that would lead to VM hangs, wrongly aborted backups or missing/bad error messages. Now tested with all permutations of * one vs two disks * iothread enabled/disabled per disk and running until sudo timeout -s SIGTERM 5s vzdump 100 --storage pbs; do; done during lunch :) Sent as seperate patches for review, last patch is for pve-qemu and contains the changes squashed in with only one new file. v2: * fix some more issues (patches 1 and 5) * fix releasing wrong AioContext after job_cancel_sync * add patch-of-patches for easier apply qemu: Stefan Reiter (5): PVE: fixup: drop CoMutex on error return PVE: Introduce generic CoCtxData struct PVE: Don't expect complete_cb to be called outside coroutine PVE: Don't call job_cancel in coroutines PVE: fix and clean up error handling for create_backup_jobs proxmox-backup-client.c | 20 +++----- proxmox-backup-client.h | 6 +++ pve-backup.c | 111 +++++++++++++++++++++++++++++----------- 3 files changed, 93 insertions(+), 44 deletions(-) qemu: Stefan Reiter (1): Several fixes for backup abort and error reporting ...ckup-proxmox-backup-patches-for-qemu.patch | 41 ++-- ...irty-bitmap-tracking-for-incremental.patch | 10 +- ...ct-stderr-to-journal-when-daemonized.patch | 2 + ...d-sequential-job-transaction-support.patch | 1 + ...-transaction-to-synchronize-job-stat.patch | 2 + ...ore-coroutines-and-don-t-block-on-fi.patch | 94 +++++---- ...n-up-error-handling-for-create_backu.patch | 187 ++++++++++++++++++ debian/patches/series | 1 + 8 files changed, 275 insertions(+), 63 deletions(-) create mode 100644 debian/patches/pve/0053-PVE-fix-and-clean-up-error-handling-for-create_backu.patch -- 2.20.1