From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9714862C25 for ; Wed, 28 Oct 2020 11:05:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8A5161DA5B for ; Wed, 28 Oct 2020 11:05:09 +0100 (CET) Received: from dev.dominic.proxmox.com (212-186-127-178.static.upcbusiness.at [212.186.127.178]) by firstgate.proxmox.com (Proxmox) with ESMTP id B4A691DA3F for ; Wed, 28 Oct 2020 11:05:08 +0100 (CET) Received: by dev.dominic.proxmox.com (Postfix, from userid 0) id 7ECFA20179; Wed, 28 Oct 2020 11:05:08 +0100 (CET) From: =?UTF-8?q?Dominic=20J=C3=A4ger?= To: pve-devel@lists.proxmox.com Date: Wed, 28 Oct 2020 11:04:54 +0100 Message-Id: <20201028100454.313122-3-d.jaeger@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201028100454.313122-1-d.jaeger@proxmox.com> References: <20201028100454.313122-1-d.jaeger@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 2 AWL -1.552 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods KHOP_HELO_FCRDNS 0.4 Relay HELO differs from its IP's reverse DNS NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record TVD_SUBJ_WIPE_DEBT 2.291 Spam advertising a way to eliminate debt URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lvmthinplugin.pm] Subject: [pve-devel] [PATCH pve-storage 3/3 v2] lvmthin: Match snapshot remove regex to allowed names X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Oct 2020 10:05:39 -0000 We allow snapshot names that match pve-configid but during qm destroy we have not removed all snapshots that match pve-configid so far. For example, the name x-y was allowed but the resulting snap_vm-105-disk-0_x-y was not removed. Reported-by: Hannes Laimer Signed-off-by: Dominic Jäger --- Requires the pve-common patches v1->v2: Use the now public regex instead of the verify function The "use constant" variant requires a backslash ${\PVE::JSONSchema::CONFIGID_RE} for each usage and the getter/method variant requires postponed regular subexpressions m/^(??{get_configid_re()})$/), so "our" looked the most simple to me. PVE/Storage/LvmThinPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Storage/LvmThinPlugin.pm b/PVE/Storage/LvmThinPlugin.pm index d1c5b1f..c9e127c 100644 --- a/PVE/Storage/LvmThinPlugin.pm +++ b/PVE/Storage/LvmThinPlugin.pm @@ -117,7 +117,7 @@ sub free_image { # remove all volume snapshots first foreach my $lv (keys %$dat) { - next if $lv !~ m/^snap_${volname}_(\w+)$/; + next if $lv !~ m/^snap_${volname}_${PVE::JSONSchema::CONFIGID_RE}$/; my $cmd = ['/sbin/lvremove', '-f', "$vg/$lv"]; run_command($cmd, errmsg => "lvremove snapshot '$vg/$lv' error"); } -- 2.20.1