From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 351BC62C26 for ; Wed, 28 Oct 2020 11:05:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2A5351DA60 for ; Wed, 28 Oct 2020 11:05:10 +0100 (CET) Received: from dev.dominic.proxmox.com (212-186-127-178.static.upcbusiness.at [212.186.127.178]) by firstgate.proxmox.com (Proxmox) with ESMTP id B1FD01DA3D for ; Wed, 28 Oct 2020 11:05:08 +0100 (CET) Received: by dev.dominic.proxmox.com (Postfix, from userid 0) id 7791B2089F; Wed, 28 Oct 2020 11:05:08 +0100 (CET) From: =?UTF-8?q?Dominic=20J=C3=A4ger?= To: pve-devel@lists.proxmox.com Date: Wed, 28 Oct 2020 11:04:52 +0100 Message-Id: <20201028100454.313122-1-d.jaeger@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.369 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods KHOP_HELO_FCRDNS 0.4 Relay HELO differs from its IP's reverse DNS NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH pve-common 1/3 v2] Add tests for verify_configid X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Oct 2020 10:05:40 -0000 Signed-off-by: Dominic Jäger --- v1->v2: Didn't exist test/Makefile | 2 +- test/format_test.pl | 27 +++++++++++++++++++++++++++ 2 files changed, 28 insertions(+), 1 deletion(-) create mode 100755 test/format_test.pl diff --git a/test/Makefile b/test/Makefile index b8118c7..85ecac5 100644 --- a/test/Makefile +++ b/test/Makefile @@ -6,7 +6,7 @@ all: export PERLLIB=../src -check: lock_file.test calendar_event_test.test convert_size_test.test procfs_tests.test +check: lock_file.test calendar_event_test.test convert_size_test.test procfs_tests.test format_test.test for d in $(SUBDIRS); do $(MAKE) -C $$d check; done %.test: %.pl diff --git a/test/format_test.pl b/test/format_test.pl new file mode 100755 index 0000000..3f225de --- /dev/null +++ b/test/format_test.pl @@ -0,0 +1,27 @@ +#!/usr/bin/perl + +use strict; +use warnings; + +use lib '../src'; +use PVE::JSONSchema; + +use Test::More; +use Test::MockModule; + +my $valid_configids = [ + 'aa', 'a0', 'a_', 'a-', 'a-a', 'a'x100, 'Aa', 'AA', +]; +my $invalid_configids = [ + 'a', 'a+', '1a', '_a', '-a', '+a', 'A', +]; + +my $noerr = 1; # easier to test +foreach my $id (@$valid_configids) { + is(PVE::JSONSchema::pve_verify_configid($id, $noerr), $id, 'valid configid'); +} +foreach my $id (@$invalid_configids) { + is(PVE::JSONSchema::pve_verify_configid($id, $noerr), undef, 'invalid configid'); +} + +done_testing(); \ No newline at end of file -- 2.20.1