From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9AED661D3F for ; Thu, 22 Oct 2020 17:35:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8EBDF21511 for ; Thu, 22 Oct 2020 17:34:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 78767214E6 for ; Thu, 22 Oct 2020 17:34:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3CF1245EE8 for ; Thu, 22 Oct 2020 17:34:29 +0200 (CEST) From: Stefan Reiter To: pve-devel@lists.proxmox.com Date: Thu, 22 Oct 2020 17:34:20 +0200 Message-Id: <20201022153420.16971-5-s.reiter@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201022153420.16971-1-s.reiter@proxmox.com> References: <20201022153420.16971-1-s.reiter@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.030 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: [pve-devel] [PATCH qemu-server 4/4] migrate: enable dirty-bitmap migration X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Oct 2020 15:35:00 -0000 We query QEMU if it's safe before enabling it, as on versions without the necessary patches it not only would be useless, but can actually lead to hangs. PBS state is always migrated, as it's a small amount of data anyway, so we don't need to set a specific flag for it. Signed-off-by: Stefan Reiter --- PVE/QemuServer.pm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index 20e284c..a282449 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -4247,6 +4247,8 @@ sub qemu_volume_snapshot_delete { sub set_migration_caps { my ($vmid) = @_; + my $qemu_support = eval { mon_cmd($vmid, "query-proxmox-support") }; + my $cap_ref = []; my $enabled_cap = { @@ -4254,7 +4256,8 @@ sub set_migration_caps { "xbzrle" => 1, "x-rdma-pin-all" => 0, "zero-blocks" => 0, - "compress" => 0 + "compress" => 0, + "dirty-bitmaps" => $qemu_support->{'pbs-dirty-bitmap-migration'} ? 1 : 0, }; my $supported_capabilities = mon_cmd($vmid, "query-migrate-capabilities"); -- 2.20.1