From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BAA3B61C26 for ; Thu, 22 Oct 2020 12:31:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 692B61F025 for ; Thu, 22 Oct 2020 12:30:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A2BA31EFBD for ; Thu, 22 Oct 2020 12:30:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5EC4B45E8F for ; Thu, 22 Oct 2020 12:30:29 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Thu, 22 Oct 2020 12:30:14 +0200 Message-Id: <20201022103017.19715-6-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201022103017.19715-1-f.ebner@proxmox.com> References: <20201022103017.19715-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.039 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [vzdump.pm] Subject: [pve-devel] [PATCH v2 manager 5/8] order guest IDs numerically in exec_backup X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Oct 2020 10:31:02 -0000 The assumption that they already are sorted is no longer valid, because of the IDs for non-existent guests. Signed-off-by: Fabian Ebner --- Should also be more future-proof to do it locally. This could be squashed into either the previous or the following patch. PVE/VZDump.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index 7ff32ce2..e1c26b42 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -1072,7 +1072,8 @@ sub exec_backup { } my $vmlist = PVE::Cluster::get_vmlist(); - foreach my $vmid (@{$opts->{vmids}}) { + my $vmids = [ sort { $a <=> $b } @{$opts->{vmids}} ]; + foreach my $vmid (@{$vmids}) { my $plugin; if (defined($vmlist->{ids}->{$vmid})) { my $guest_type = $vmlist->{ids}->{$vmid}->{type}; -- 2.20.1