From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2E44260C49 for ; Mon, 19 Oct 2020 14:33:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 252A72CC29 for ; Mon, 19 Oct 2020 14:33:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4996A2CC1F for ; Mon, 19 Oct 2020 14:33:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0BE6B45DFB for ; Mon, 19 Oct 2020 14:33:19 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Mon, 19 Oct 2020 14:33:14 +0200 Message-Id: <20201019123314.8303-3-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201019123314.8303-1-f.ebner@proxmox.com> References: <20201019123314.8303-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.293 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 3/3] fix #2745: backup GUI: allow users to specify remove=1 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Oct 2020 12:33:50 -0000 A user with Datastore.AllocateSpace, VM.Audit, VM.Backup privileges can already remove backups from the GUI manually, so it shouldn't be a problem if they can set the remove flag when starting a manual vzdump job in the GUI. Signed-off-by: Fabian Ebner --- www/manager6/window/Backup.js | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js index 55f52676..8649c738 100644 --- a/www/manager6/window/Backup.js +++ b/www/manager6/window/Backup.js @@ -67,8 +67,19 @@ Ext.define('PVE.window.Backup', { fieldLabel: gettext('Send email to'), name: 'mailto', emptyText: Proxmox.Utils.noneText - } - ] + }, + { + xtype: 'proxmoxcheckbox', + name: 'remove', + checked: false, + uncheckedValue: 0, + fieldLabel: gettext('Remove'), + autoEl: { + tag: 'div', + 'data-qtip': gettext('Remove/prune older backups afterwards'), + }, + }, + ], }); var form = me.formPanel.getForm(); @@ -82,7 +93,7 @@ Ext.define('PVE.window.Backup', { storage: storage, vmid: me.vmid, mode: values.mode, - remove: 0 + remove: values.remove, }; if ( values.mailto ) { -- 2.20.1