From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 25D2860C48 for ; Mon, 19 Oct 2020 14:33:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1D02C2CC27 for ; Mon, 19 Oct 2020 14:33:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2913B2CC14 for ; Mon, 19 Oct 2020 14:33:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E7A7145DF4 for ; Mon, 19 Oct 2020 14:33:18 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Mon, 19 Oct 2020 14:33:13 +0200 Message-Id: <20201019123314.8303-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201019123314.8303-1-f.ebner@proxmox.com> References: <20201019123314.8303-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.043 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 2/3] partially fix #2745: use default for vzdump remove parameter X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Oct 2020 12:33:50 -0000 The initial default from the $confdesc is 1 anyways, and like this, changing the default in /etc/vzdump.conf to 0 actually works. Signed-off-by: Fabian Ebner --- PVE/VZDump.pm | 2 -- 1 file changed, 2 deletions(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index 542228d6..3ccb8269 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -411,8 +411,6 @@ sub new { my $defaults = read_vzdump_defaults(); - $opts->{remove} = 1 if !defined($opts->{remove}); - foreach my $k (keys %$defaults) { next if $k eq 'exclude-path' || $k eq 'maxfiles'; # dealt with separately if ($k eq 'dumpdir' || $k eq 'storage') { -- 2.20.1