From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E61EA60B43 for ; Mon, 19 Oct 2020 14:19:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DB1D02C5F7 for ; Mon, 19 Oct 2020 14:19:44 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B3F182C5D6 for ; Mon, 19 Oct 2020 14:19:43 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 7A5CF45E1C for ; Mon, 19 Oct 2020 14:19:43 +0200 (CEST) From: Stefan Reiter To: pve-devel@lists.proxmox.com Cc: d.csapak@proxmox.com, w.bumiller@proxmox.com Date: Mon, 19 Oct 2020 14:18:39 +0200 Message-Id: <20201019121842.20277-5-s.reiter@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201019121842.20277-1-s.reiter@proxmox.com> References: <20201019121842.20277-1-s.reiter@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.036 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH v2 qemu-server 4/7] vzdump: use dirty bitmap for not running VMs too X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Oct 2020 12:19:45 -0000 Now that VMs can be started during a backup, it makes sense to create a dirty bitmap in these cases too, since the VM might be resumed and thus continue running normally even after the backup is done. Signed-off-by: Stefan Reiter --- PVE/VZDump/QemuServer.pm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm index ccfb214..ee9896c 100644 --- a/PVE/VZDump/QemuServer.pm +++ b/PVE/VZDump/QemuServer.pm @@ -299,8 +299,7 @@ my $bitmap_action_to_human = sub { my $action = $info->{action}; if ($action eq "not-used") { - return "disabled (no support)" if $self->{vm_was_running}; - return "disabled (VM not running)"; + return "disabled (no support)"; } elsif ($action eq "not-used-removed") { return "disabled (old bitmap cleared)"; } elsif ($action eq "new") { @@ -554,7 +553,7 @@ sub archive_pbs { my $is_template = PVE::QemuConfig->is_template($self->{vmlist}->{$vmid}); $params->{'use-dirty-bitmap'} = JSON::true - if $qemu_support->{'pbs-dirty-bitmap'} && $self->{vm_was_running} && !$is_template; + if $qemu_support->{'pbs-dirty-bitmap'} && !$is_template; $params->{timeout} = 60; # give some time to connect to the backup server -- 2.20.1