From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 28362607BA for ; Thu, 15 Oct 2020 12:00:47 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 24C8C119A1 for ; Thu, 15 Oct 2020 12:00:47 +0200 (CEST) Received: from dev.dominic.proxmox.com (212-186-127-178.static.upcbusiness.at [212.186.127.178]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8F17C1198D for ; Thu, 15 Oct 2020 12:00:46 +0200 (CEST) Received: by dev.dominic.proxmox.com (Postfix, from userid 0) id 6862B21DC9; Thu, 15 Oct 2020 12:00:46 +0200 (CEST) From: =?UTF-8?q?Dominic=20J=C3=A4ger?= To: pve-devel@lists.proxmox.com Date: Thu, 15 Oct 2020 12:00:18 +0200 Message-Id: <20201015100019.311138-1-d.jaeger@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.549 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods KHOP_HELO_FCRDNS 0.4 Relay HELO differs from its IP's reverse DNS NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH manager] ui: Fix #2827: Add verify SSL cert checkbox for ldap X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Oct 2020 10:00:47 -0000 Because the option is too important to be hidden in CLI. Signed-off-by: Dominic Jäger --- I haven't managed to test this against an LDAP server yet, but the GUI elements go on and off as I had it in mind and the options in /etc/pve/domains.cfg change as expected. www/manager6/dc/AuthEditLDAP.js | 35 +++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) diff --git a/www/manager6/dc/AuthEditLDAP.js b/www/manager6/dc/AuthEditLDAP.js index c5976769..ccaabc4e 100644 --- a/www/manager6/dc/AuthEditLDAP.js +++ b/www/manager6/dc/AuthEditLDAP.js @@ -53,11 +53,46 @@ Ext.define('PVE.panel.LDAPInputPanel', { fieldLabel: 'SSL', name: 'secure', uncheckedValue: 0, + listeners: { + change: function(me, newValue) { + let verifyCheckbox = me.nextSibling('proxmoxcheckbox[name=verify]'); + if (newValue === true) { + verifyCheckbox.enable(); + } else { + verifyCheckbox.disable(); + verifyCheckbox.setValue(0); + } + }, + }, + }, + { + xtype: 'proxmoxcheckbox', + fieldLabel: gettext('Verify Certificate'), + name: 'verify', + unceckedValue: 0, + disabled: true, + checked: false, + autoEl: { + tag: 'div', + 'data-qtip': gettext('Verify SSL certificate of the server'), + }, }, ]; me.callParent(); }, + onGetValues: function(values) { + let me = this; + + if (!values.verify) { + if (!me.isCreate) { + Proxmox.Utils.assemble_field_data(values, { 'delete': 'verify' }); + } + delete values.verify; + } + + return me.callParent([values]); + }, }); Ext.define('PVE.panel.LDAPSyncInputPanel', { -- 2.20.1