From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F19F2638B8 for ; Mon, 5 Oct 2020 14:14:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D9E461A2A8 for ; Mon, 5 Oct 2020 14:13:46 +0200 (CEST) Received: from gaia.proxmox.com (212-186-127-178.static.upcbusiness.at [212.186.127.178]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id ACF8D1A29E for ; Mon, 5 Oct 2020 14:13:43 +0200 (CEST) Received: from gaia.proxmox.com (localhost.localdomain [127.0.0.1]) by gaia.proxmox.com (8.15.2/8.15.2/Debian-14~deb10u1) with ESMTP id 095CDh5s2920514; Mon, 5 Oct 2020 14:13:43 +0200 Received: (from oguz@localhost) by gaia.proxmox.com (8.15.2/8.15.2/Submit) id 095CDhQ22920513; Mon, 5 Oct 2020 14:13:43 +0200 From: Oguz Bektas To: pve-devel@lists.proxmox.com Date: Mon, 5 Oct 2020 14:13:41 +0200 Message-Id: <20201005121341.2920388-1-o.bektas@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.709 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods KHOP_HELO_FCRDNS 0.398 Relay HELO differs from its IP's reverse DNS NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH installer] fix #3057: remove ext3 option from installer X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Oct 2020 12:14:17 -0000 we can safely remove this from the fs options nobody uses this anymore, and it just ends up causing problems like in [0] [0]: https://forum.proxmox.com/threads/emlink-too-many-links.73108/ Signed-off-by: Oguz Bektas --- proxinstall | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/proxinstall b/proxinstall index 4fb0748..8b0a2cb 100755 --- a/proxinstall +++ b/proxinstall @@ -279,7 +279,7 @@ my $config = { my $config_options = {}; -if ($cmdline =~ m/\s(ext3|ext4|xfs)(\s.*)?$/) { +if ($cmdline =~ m/\s(ext4|xfs)(\s.*)?$/) { $config_options->{filesys} = $1; } else { $config_options->{filesys} = 'ext4'; @@ -774,12 +774,6 @@ sub update_progress { } my $fssetup = { - ext3 => { - mkfs => 'mkfs.ext3 -F', - mkfs_root_opt => '', - mkfs_data_opt => '-m 0', - root_mountopt => 'errors=remount-ro', - }, ext4 => { mkfs => 'mkfs.ext4 -F', mkfs_root_opt => '', @@ -2982,7 +2976,7 @@ sub create_hdoption_view { my $fstypecb = Gtk3::ComboBoxText->new(); - my $fstype = ['ext3', 'ext4', 'xfs', + my $fstype = ['ext4', 'xfs', 'zfs (RAID0)', 'zfs (RAID1)', 'zfs (RAID10)', 'zfs (RAIDZ-1)', 'zfs (RAIDZ-2)', 'zfs (RAIDZ-3)']; -- 2.20.1