From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 61C8962D19 for ; Thu, 1 Oct 2020 13:15:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 52115209A2 for ; Thu, 1 Oct 2020 13:15:43 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 262B120977 for ; Thu, 1 Oct 2020 13:15:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DDF5B45B70 for ; Thu, 1 Oct 2020 13:15:40 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Thu, 1 Oct 2020 13:15:35 +0200 Message-Id: <20201001111535.13721-4-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201001111535.13721-1-f.ebner@proxmox.com> References: <20201001111535.13721-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.048 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [replication.pm] Subject: [pve-devel] [PATCH guest-common 4/4] cleanup storeid_list creation X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Oct 2020 11:15:43 -0000 Signed-off-by: Fabian Ebner --- Not sure if the expression for map{} is too cluttered here... PVE/Replication.pm | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/PVE/Replication.pm b/PVE/Replication.pm index 60cfc67..132e8bb 100644 --- a/PVE/Replication.pm +++ b/PVE/Replication.pm @@ -262,12 +262,8 @@ sub replicate { my ($base_snapshots, $last_snapshots, $last_sync_snapname) = find_common_replication_snapshot( $ssh_info, $jobid, $vmid, $storecfg, $sorted_volids, $state->{storeid_list}, $last_sync, $parent_snapname, $logfunc); - my $storeid_hash = {}; - foreach my $volid (@$sorted_volids) { - my ($storeid) = PVE::Storage::parse_volume_id($volid); - $storeid_hash->{$storeid} = 1; - } - $state->{storeid_list} = [ sort keys %$storeid_hash ]; + my %storeid_hash = map { (PVE::Storage::parse_volume_id($_))[0] => 1 } @$sorted_volids; + $state->{storeid_list} = [ sort keys %storeid_hash ]; # freeze filesystem for data consistency if ($freezefs) { -- 2.20.1