From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B59CA629EE for ; Thu, 17 Sep 2020 21:17:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E73FA1009C for ; Thu, 17 Sep 2020 21:17:21 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 87B5210086 for ; Thu, 17 Sep 2020 21:17:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4F59C45424 for ; Thu, 17 Sep 2020 21:17:20 +0200 (CEST) From: Stoiko Ivanov To: pve-devel@lists.proxmox.com Date: Thu, 17 Sep 2020 21:16:59 +0200 Message-Id: <20200917191701.2236-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.020 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [tools.pm, lxc.pm] Subject: [pve-devel] [PATCH common/container] fix syncfs usage for snapshot backup X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Sep 2020 19:17:23 -0000 while investigating #2991 (and probably related #1911) I straced pvedaemon noticing that the syncfs-calls all failed (errno EBADF). This happens because we open the mountpoint path with O_PATH (open(2)), which causes syncfs to fail. Since I expect syncfs failing to be a potential cause for the inconstent state of containers on ceph-storages while backing up in snapshot mode this patchset hopefully mitigates the reported issues. (if this is not the solution, I was also investigating calling ioctl(fd, FIFREEZE) on the mountpoint before creating the snapshot) The patch to pve-container is maybe not necessary, but should save us a few syscalls, which don't help. Would be grateful for review from more experienced eyes - I ran limted tests with the patches applied - creating snapshot backups on a container with lvmthin backed rootfs and on one with ceph backed rootfs. pve-common Stoiko Ivanov (1): sync_mountpoint: open path so that sync works src/PVE/Tools.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) pve-container: Stoiko Ivanov (1): sync_container_namespace: skip virtual filesystems src/PVE/LXC.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1