From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8A45A6259A for ; Wed, 16 Sep 2020 14:51:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3E68424409 for ; Wed, 16 Sep 2020 14:51:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 207A8240F8 for ; Wed, 16 Sep 2020 14:50:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CB268453EC for ; Wed, 16 Sep 2020 14:50:51 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Wed, 16 Sep 2020 14:50:37 +0200 Message-Id: <20200916125041.4151-17-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200916125041.4151-1-f.ebner@proxmox.com> References: <20200916125041.4151-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.055 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [RFC v2 manager 16/20] content view: allow specifying which columns to show on init X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Sep 2020 12:51:33 -0000 depending on the content type we might want to show different information, e.g. parent for cloned VM/CT images (would have to be added to the model first) Signed-off-by: Fabian Ebner --- www/manager6/storage/ContentView.js | 60 +++++++++++++++++------------ 1 file changed, 35 insertions(+), 25 deletions(-) diff --git a/www/manager6/storage/ContentView.js b/www/manager6/storage/ContentView.js index 3b6b817a..0f1bbc0c 100644 --- a/www/manager6/storage/ContentView.js +++ b/www/manager6/storage/ContentView.js @@ -311,35 +311,45 @@ Ext.define('PVE.storage.ContentView', { } ); + var availableColumns = { + 'name': { + header: gettext('Name'), + flex: 1, + sortable: true, + renderer: PVE.Utils.render_storage_content, + dataIndex: 'text' + }, + 'date': { + header: gettext('Date'), + width: 150, + dataIndex: 'vdate' + }, + 'format': { + header: gettext('Format'), + width: 100, + dataIndex: 'format' + }, + 'size': { + header: gettext('Size'), + width: 100, + renderer: Proxmox.Utils.format_size, + dataIndex: 'size' + }, + }; + + if (!me.showColumns) { + me.showColumns = ['name', 'date', 'format', 'size']; + } + var columns = []; + me.showColumns.forEach(function(datum) { + columns.push(availableColumns[datum]); + }); + Ext.apply(me, { store: store, selModel: sm, tbar: me.tbar, - columns: [ - { - header: gettext('Name'), - flex: 1, - sortable: true, - renderer: PVE.Utils.render_storage_content, - dataIndex: 'text' - }, - { - header: gettext('Date'), - width: 150, - dataIndex: 'vdate' - }, - { - header: gettext('Format'), - width: 100, - dataIndex: 'format' - }, - { - header: gettext('Size'), - width: 100, - renderer: Proxmox.Utils.format_size, - dataIndex: 'size' - } - ], + columns: columns, listeners: { activate: reload } -- 2.20.1