From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <o.bektas@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8C6B461B3A for <pve-devel@lists.proxmox.com>; Tue, 15 Sep 2020 11:06:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 75FE917E07 for <pve-devel@lists.proxmox.com>; Tue, 15 Sep 2020 11:06:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 9FBC117DFD for <pve-devel@lists.proxmox.com>; Tue, 15 Sep 2020 11:06:21 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6646044C0B for <pve-devel@lists.proxmox.com>; Tue, 15 Sep 2020 11:06:21 +0200 (CEST) Date: Tue, 15 Sep 2020 11:06:19 +0200 From: Oguz Bektas <o.bektas@proxmox.com> To: Thomas Lamprecht <t.lamprecht@proxmox.com> Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Message-ID: <20200915090619.GA9976@gaia.proxmox.com> Mail-Followup-To: Oguz Bektas <o.bektas@proxmox.com>, Thomas Lamprecht <t.lamprecht@proxmox.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20200914103216.320620-1-o.bektas@proxmox.com> <20200914103216.320620-2-o.bektas@proxmox.com> <9d6aed9b-2218-5f05-ec06-3fa93054c20c@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9d6aed9b-2218-5f05-ec06-3fa93054c20c@proxmox.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-SPAM-LEVEL: Spam detection results: 0 AWL 0.999 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [config.pm, proxmox.com] Subject: Re: [pve-devel] [PATCH container 1/2] fix #2938: increase limit of max cores from 128 to 512 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Tue, 15 Sep 2020 09:06:52 -0000 On Tue, Sep 15, 2020 at 11:03:52AM +0200, Thomas Lamprecht wrote: > On 9/14/20 12:32 PM, Oguz Bektas wrote: > > Signed-off-by: Oguz Bektas <o.bektas@proxmox.com> > > --- > > src/PVE/LXC/Config.pm | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm > > index 4cd669c..223b10e 100644 > > --- a/src/PVE/LXC/Config.pm > > +++ b/src/PVE/LXC/Config.pm > > @@ -401,14 +401,14 @@ my $confdesc = { > > type => 'integer', > > description => "The number of cores assigned to the container. A container can use all available cores by default.", > > minimum => 1, > > - maximum => 128, > > + maximum => 512, > > }, > > cpulimit => { > > optional => 1, > > type => 'number', > > description => "Limit of CPU usage.\n\nNOTE: If the computer has 2 CPUs, it has a total of '2' CPU time. Value '0' indicates no CPU limit.", > > minimum => 0, > > - maximum => 128, > > + maximum => 512, > > default => 0, > > }, > > cpuunits => { > > > > why 512? please give state some actual reason for choosing such a number, > especially if it differs from our current kernel config value of 8192... > > https://git.proxmox.com/?p=mirror_ubuntu-focal-kernel.git;a=blob;f=arch/x86/Kconfig;h=8ef85139553f5a4ad5187375af898266355c4177;hb=b311b46c7d1ab21bf0a11a6fa5bad76f98fb77af#l1014 it was a somewhat arbitrary value i picked, sounded big enough but i guess you're right :)