From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B2D0060B68 for ; Thu, 10 Sep 2020 14:57:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 95E921C572 for ; Thu, 10 Sep 2020 14:57:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 03D631C54D for ; Thu, 10 Sep 2020 14:57:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B6D9444B04 for ; Thu, 10 Sep 2020 14:57:12 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Thu, 10 Sep 2020 14:57:09 +0200 Message-Id: <20200910125711.28369-4-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200910125711.28369-1-d.csapak@proxmox.com> References: <20200910125711.28369-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.123 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH RFC manager 2/2] ui: grid/Replication: change the default format of schedule text X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Sep 2020 12:57:44 -0000 we want to sometimes elminiate the 'minute-only' syntax, so change the defaults from '*/15' to the semantically identical '*:00/15' make the replication edit window a bit wider to show the complete empty text Signed-off-by: Dominik Csapak --- www/manager6/grid/Replication.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/www/manager6/grid/Replication.js b/www/manager6/grid/Replication.js index 19e67d90..c1f756b4 100644 --- a/www/manager6/grid/Replication.js +++ b/www/manager6/grid/Replication.js @@ -4,6 +4,7 @@ Ext.define('PVE.window.ReplicaEdit', { subject: gettext('Replication Job'), + width: 350, url: '/cluster/replication', method: 'POST', @@ -35,7 +36,7 @@ Ext.define('PVE.window.ReplicaEdit', { { xtype: 'pveCalendarEvent', fieldLabel: gettext('Schedule'), - emptyText: '*/15 - ' + Ext.String.format(gettext('Every {0} minutes'), 15), + emptyText: '*:00/15 - ' + Ext.String.format(gettext('Every {0} minutes'), 15), name: 'schedule' }, { @@ -74,7 +75,7 @@ Ext.define('PVE.window.ReplicaEdit', { PVE.Utils.delete_if_default(values, 'rate', '', me.isCreate); PVE.Utils.delete_if_default(values, 'disable', 0, me.isCreate); - PVE.Utils.delete_if_default(values, 'schedule', '*/15', me.isCreate); + PVE.Utils.delete_if_default(values, 'schedule', '*:00/15', me.isCreate); PVE.Utils.delete_if_default(values, 'comment', '', me.isCreate); if (me.isCreate) { @@ -481,7 +482,7 @@ Ext.define('PVE.grid.ReplicaView', { 'id', 'target', 'comment', 'rate', 'type', { name: 'guest', type: 'integer' }, { name: 'jobnum', type: 'integer' }, - { name: 'schedule', defaultValue: '*/15' }, + { name: 'schedule', defaultValue: '*:00/15' }, { name: 'disable', defaultValue: '' }, { name: 'enabled', calculate: function(data) { return !data.disable; } } ] -- 2.20.1