From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8AFEE60605 for ; Wed, 2 Sep 2020 13:03:49 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 890A310140 for ; Wed, 2 Sep 2020 13:03:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4C14E100EB for ; Wed, 2 Sep 2020 13:03:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0D828449CF for ; Wed, 2 Sep 2020 13:03:47 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Wed, 2 Sep 2020 13:03:24 +0200 Message-Id: <20200902110337.25004-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200902110337.25004-1-f.ebner@proxmox.com> References: <20200902110337.25004-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.048 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager 01/14] config panel: allow new nodes to be added later X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Sep 2020 11:03:49 -0000 in preparation for dynamically loading nodes for content-type-specific views. Signed-off-by: Fabian Ebner --- www/manager6/panel/ConfigPanel.js | 93 +++++++++++++++++-------------- 1 file changed, 50 insertions(+), 43 deletions(-) diff --git a/www/manager6/panel/ConfigPanel.js b/www/manager6/panel/ConfigPanel.js index 4356c24e..fabf9108 100644 --- a/www/manager6/panel/ConfigPanel.js +++ b/www/manager6/panel/ConfigPanel.js @@ -227,48 +227,7 @@ Ext.define('PVE.panel.Config', { } }); var root = me.store.getRoot(); - me.items.forEach(function(item){ - var treeitem = Ext.create('Ext.data.TreeModel',{ - id: item.itemId, - text: item.title, - iconCls: item.iconCls, - leaf: true, - expanded: item.expandedOnInit - }); - item.header = false; - if (me.savedItems[item.itemId] !== undefined) { - throw "itemId already exists, please use another"; - } - me.savedItems[item.itemId] = item; - - var group; - var curnode = root; - - // get/create the group items - while (Ext.isArray(item.groups) && item.groups.length > 0) { - group = item.groups.shift(); - - var child = curnode.findChild('id', group); - if (child === null) { - // did not find the group item - // so add it where we are - break; - } - curnode = child; - } - - // insert the item - - // lets see if it already exists - var node = curnode.findChild('id', item.itemId); - - if (node === null) { - curnode.appendChild(treeitem); - } else { - // should not happen! - throw "id already exists"; - } - }); + me.insertNodes(me.items); delete me.items; me.defaults = me.defaults || {}; @@ -310,5 +269,53 @@ Ext.define('PVE.panel.Config', { if (stateid) { me.mon(me.sp, 'statechange', statechange); } - } + }, + + insertNodes: function(items) { + var me = this; + var root = me.store.getRoot(); + + items.forEach(function(item) { + var treeitem = Ext.create('Ext.data.TreeModel',{ + id: item.itemId, + text: item.title, + iconCls: item.iconCls, + leaf: true, + expanded: item.expandedOnInit + }); + item.header = false; + if (me.savedItems[item.itemId] !== undefined) { + throw "itemId already exists, please use another"; + } + me.savedItems[item.itemId] = item; + + var group; + var curnode = root; + + // get/create the group items + while (Ext.isArray(item.groups) && item.groups.length > 0) { + group = item.groups.shift(); + + var child = curnode.findChild('id', group); + if (child === null) { + // did not find the group item + // so add it where we are + break; + } + curnode = child; + } + + // insert the item + + // lets see if it already exists + var node = curnode.findChild('id', item.itemId); + + if (node === null) { + curnode.appendChild(treeitem); + } else { + // should not happen! + throw "id already exists"; + } + }); + }, }); -- 2.20.1