From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <f.ebner@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C45906061E for <pve-devel@lists.proxmox.com>; Wed, 2 Sep 2020 13:04:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BABE010113 for <pve-devel@lists.proxmox.com>; Wed, 2 Sep 2020 13:03:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1CA28100E3 for <pve-devel@lists.proxmox.com>; Wed, 2 Sep 2020 13:03:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DC268449B8 for <pve-devel@lists.proxmox.com>; Wed, 2 Sep 2020 13:03:46 +0200 (CEST) From: Fabian Ebner <f.ebner@proxmox.com> To: pve-devel@lists.proxmox.com Date: Wed, 2 Sep 2020 13:03:23 +0200 Message-Id: <20200902110337.25004-1-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.051 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH-SERIES/RFC manager 00/14] split up content view into a view for each type X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 02 Sep 2020 11:04:18 -0000 The goal of doing this is to have more flexibility/cleaner code for content-type-dependent features in the content view. Now only buttons that are useful for each content type are displayed. And it might make sense to display different columns for different content types, e.g. 'parent' for cloned VM/CT images. The mechanism introduced in this series (patch #13) is not used yet, suggestions for which columns to use for which types are welcome. API calls might be faster if only one type of content is requested. The obvious drawback is that there is no view with all contents anymore. The last patch is not directly related, but introduces the prune window for backups, essentially copied over from the PBS code. @Thomas: Hope this is not too far from what you had in mind. Of course I can rebase the prune window patch on current master if prefer. Fabian Ebner (14): config panel: allow new nodes to be added later storage panel/browser: use insertNodes function use separate view for each content type remove the now unneccessary grouping content view: allow specifying title bar elements for init turn nodename,storage,sm into object variables add upload button conditionally create and use TemplateView create and use BackupView get rid of unneccessary enableFn's create ImageView and use it for VM and CT images simplify reload call content view: allow specifying which columns to show on init backup view: add prune window www/manager6/Makefile | 4 + www/manager6/panel/ConfigPanel.js | 93 ++--- www/manager6/storage/BackupView.js | 96 ++++++ www/manager6/storage/Browser.js | 89 ++++- www/manager6/storage/ContentView.js | 497 +++++---------------------- www/manager6/storage/ImageView.js | 74 ++++ www/manager6/storage/TemplateView.js | 212 ++++++++++++ www/manager6/window/Prune.js | 230 +++++++++++++ 8 files changed, 836 insertions(+), 459 deletions(-) create mode 100644 www/manager6/storage/BackupView.js create mode 100644 www/manager6/storage/ImageView.js create mode 100644 www/manager6/storage/TemplateView.js create mode 100644 www/manager6/window/Prune.js -- 2.20.1