From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <d.jaeger@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 0EC0069721
 for <pve-devel@lists.proxmox.com>; Mon, 31 Aug 2020 13:04:51 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 04EC61352B
 for <pve-devel@lists.proxmox.com>; Mon, 31 Aug 2020 13:04:51 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 83E4413520
 for <pve-devel@lists.proxmox.com>; Mon, 31 Aug 2020 13:04:50 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5685A44960
 for <pve-devel@lists.proxmox.com>; Mon, 31 Aug 2020 13:04:50 +0200 (CEST)
Date: Mon, 31 Aug 2020 13:04:48 +0200
From: Dominic =?iso-8859-1?Q?J=E4ger?= <d.jaeger@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Message-ID: <20200831110448.GC120313@mala.proxmox.com>
References: <20200825151426.17428-1-a.lauterer@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200825151426.17428-1-a.lauterer@proxmox.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-SPAM-LEVEL: Spam detection results:  0
 AWL 1.534 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH series 0/4] Add GUI for disk reassignment
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 31 Aug 2020 11:04:51 -0000

I reassigned some disks and it seemed to work nice for me :)
Error messages about unavailable disks for running VMs and equal source and
target VM made sense to me, correct possible targets were displayed, multiple
storages worked.

One thing that came to my mind: It might make sense to display what name the
reassigned disk got in the target VM in the log.
For example "Reassigned to VM 123 as Unused Disk 7 [maybe with volid]".
Because if there are multiple unused disks on the target VM it could happen
that it's not the one with the highest number?

On Tue, Aug 25, 2020 at 05:14:22PM +0200, Aaron Lauterer wrote:
> This patch series adds the GUI to the recent patch series [0] which
> enables the reassignment of disks between VMs.
> 
> For this to work, the previous patch series [0] needs to be applied and
> installed.