From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 637C968E7D for ; Fri, 28 Aug 2020 14:37:38 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F232720EE8 for ; Fri, 28 Aug 2020 14:37:07 +0200 (CEST) Received: from mailpro.odiso.net (mailpro.odiso.net [89.248.211.110]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6909320E4B for ; Fri, 28 Aug 2020 14:37:01 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mailpro.odiso.net (Postfix) with ESMTP id 2972315F9E0C; Fri, 28 Aug 2020 14:36:56 +0200 (CEST) Received: from mailpro.odiso.net ([127.0.0.1]) by localhost (mailpro.odiso.net [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id OaxuCbQHBr22; Fri, 28 Aug 2020 14:36:56 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mailpro.odiso.net (Postfix) with ESMTP id 1007515F9E09; Fri, 28 Aug 2020 14:36:56 +0200 (CEST) X-Virus-Scanned: amavisd-new at mailpro.odiso.com Received: from mailpro.odiso.net ([127.0.0.1]) by localhost (mailpro.odiso.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id LGBizpvP7jcz; Fri, 28 Aug 2020 14:36:56 +0200 (CEST) Received: from pve.fritz.box (unknown [213.211.148.86]) by mailpro.odiso.net (Postfix) with ESMTPSA id D549A15F9DAB; Fri, 28 Aug 2020 14:36:55 +0200 (CEST) From: Alexandre Derumier To: pve-devel@lists.proxmox.com Date: Fri, 28 Aug 2020 14:36:35 +0200 Message-Id: <20200828123649.11125-8-aderumier@odiso.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200828123649.11125-1-aderumier@odiso.com> References: <20200828123649.11125-1-aderumier@odiso.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [subnetplugin.pm] Subject: [pve-devel] [PATCH v7 pve-network 07/21] subnet: fix on_delete_hook X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2020 12:37:38 -0000 --- PVE/Network/SDN/SubnetPlugin.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PVE/Network/SDN/SubnetPlugin.pm b/PVE/Network/SDN/SubnetPlug= in.pm index c555314..ea47684 100644 --- a/PVE/Network/SDN/SubnetPlugin.pm +++ b/PVE/Network/SDN/SubnetPlugin.pm @@ -116,12 +116,12 @@ sub on_delete_hook { my ($class, $subnetid, $subnet_cfg, $vnet_cfg) =3D @_; =20 #verify if vnets have subnet - foreach my $id (keys %{$vnet_cfg->{ids}}) { - my $vnet =3D $vnet_cfg->{ids}->{$id}; + foreach my $vnetid (keys %{$vnet_cfg->{ids}}) { + my $vnet =3D $vnet_cfg->{ids}->{$vnetid}; my @subnets =3D PVE::Tools::split_list($vnet->{subnets}) if $vnet->{sub= nets}; foreach my $subnet (@subnets) { my $id =3D $subnet =3D~ s/\//-/r; - raise_param_exc({ subnet =3D> "$subnet is attached to vnet $id"}) i= f $id eq $subnetid; + raise_param_exc({ subnet =3D> "$subnet is attached to vnet $vnetid"= }) if $id eq $subnetid; } } =20 --=20 2.20.1