From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1E66E67149 for ; Tue, 25 Aug 2020 17:14:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 137CE8771 for ; Tue, 25 Aug 2020 17:14:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E91AB86F0 for ; Tue, 25 Aug 2020 17:14:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AD19544887 for ; Tue, 25 Aug 2020 17:14:26 +0200 (CEST) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Tue, 25 Aug 2020 17:14:23 +0200 Message-Id: <20200825151426.17428-2-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200825151426.17428-1-a.lauterer@proxmox.com> References: <20200825151426.17428-1-a.lauterer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.036 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH widget-toolkit 1/4] window/edit: add option to disable reset button X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Aug 2020 15:14:28 -0000 Sometimes the reset button does not make sense and the isCreate option does not fit as well because with it, the submit button will be enabled right away instead of waiting for the form to be valid. Signed-off-by: Aaron Lauterer --- This helps to reuse the PVE.window.Edit component in a modern viewModel and controller way instead of building it all by hand the old way with a large initComponent method. A possible candidate for refactoring after this would be the qemu/HDMove.js component. src/window/Edit.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/window/Edit.js b/src/window/Edit.js index 2dfab19..9ca314d 100644 --- a/src/window/Edit.js +++ b/src/window/Edit.js @@ -22,6 +22,9 @@ Ext.define('Proxmox.window.Edit', { // set to true if you want an Remove button (instead of Create) isRemove: false, + // set to false, if you don't want the reset button present + showReset: true, + // custom submitText submitText: undefined, @@ -326,7 +329,7 @@ Ext.define('Proxmox.window.Edit', { me.title = Proxmox.Utils.dialog_title(me.subject, me.isCreate, me.isAdd); } - if (me.isCreate) { + if (me.isCreate || !me.showReset) { me.buttons = [submitBtn]; } else { me.buttons = [submitBtn, resetBtn]; -- 2.20.1