From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0828761A46 for ; Wed, 19 Aug 2020 10:35:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DBB6D19F76 for ; Wed, 19 Aug 2020 10:35:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C13E319E03 for ; Wed, 19 Aug 2020 10:35:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8DA2A4469E for ; Wed, 19 Aug 2020 10:35:47 +0200 (CEST) From: Aaron Lauterer To: pve-devel@lists.proxmox.com Date: Wed, 19 Aug 2020 10:35:40 +0200 Message-Id: <20200819083545.27992-1-a.lauterer@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.037 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lvmplugin.pm, cephfsplugin.pm, storage.pm, rbdplugin.pm, qemu.pm, iscsiplugin.pm, glusterfsplugin.pm, drbdplugin.pm, drive.pm, plugin.pm, iscsidirectplugin.pm, zfspoolplugin.pm, zfsplugin.pm, qm.pm] Subject: [pve-devel] [PATCH series v1 0/5] disk reassign: add new feature X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Aug 2020 08:35:53 -0000 This RFC series implements a new feature which allows users to easily reassign disks between VMs. Currently this is only possible with one of the following manual steps: * rename the disk image/file and do a `qm rescan` * configure the disk manually and use the old image name, having an image for VM A assigned to VM B The latter can cause unexpected behavior because PVE expects that the VMID in a disk name always corresponds to the VM it is assigned to. Thus when a disk, original from VM A was manually configured as disk for VM B it happens that, when deleting VM A, the disk in question will be deleted as well because it still had the VMID of VM A in it's name. To issue a reassign from the CLI run: qm reassign_disk where is the config key of the disk, e.g. ide0, scsi1 and so on. The following storage types are implemented at the moment: * dir based ones * directory * NFS * CIFS * ZFS * (thin) LVM * Ceph RBD Changes from RFC -> V1: * support to reassign unused disks * digest for target vm config * reorder the checks a bit * adding another one to check if the given key for the disk even exists in the config. qemu-server: Aaron Lauterer (2): disk reassign: add API endpoint cli: disk reassign: add reassign_disk to qm command PVE/API2/Qemu.pm | 106 ++++++++++++++++++++++++++++++++++++++++ PVE/CLI/qm.pm | 2 + PVE/QemuServer/Drive.pm | 4 ++ 3 files changed, 112 insertions(+) storage: Aaron Lauterer (2): add disk reassign feature disk reassign: add not implemented yet message to storages PVE/Storage.pm | 10 ++++++++++ PVE/Storage/CephFSPlugin.pm | 5 +++++ PVE/Storage/DRBDPlugin.pm | 5 +++++ PVE/Storage/GlusterfsPlugin.pm | 5 +++++ PVE/Storage/ISCSIDirectPlugin.pm | 5 +++++ PVE/Storage/ISCSIPlugin.pm | 4 ++++ PVE/Storage/LVMPlugin.pm | 15 +++++++++++++++ PVE/Storage/Plugin.pm | 21 +++++++++++++++++++++ PVE/Storage/RBDPlugin.pm | 13 +++++++++++++ PVE/Storage/ZFSPlugin.pm | 5 +++++ PVE/Storage/ZFSPoolPlugin.pm | 9 +++++++++ 11 files changed, 97 insertions(+) widget-toolkit: Aaron Lauterer (1): utils: task_desc_table: add qmreassign src/Utils.js | 1 + 1 file changed, 1 insertion(+) -- 2.20.1