From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id ECBF06097F for ; Thu, 13 Aug 2020 14:03:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E27AD19E7B for ; Thu, 13 Aug 2020 14:03:54 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C639619E5A for ; Thu, 13 Aug 2020 14:03:53 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8E5DA445D8 for ; Thu, 13 Aug 2020 14:03:53 +0200 (CEST) From: Stefan Reiter To: pve-devel@lists.proxmox.com Date: Thu, 13 Aug 2020 14:03:34 +0200 Message-Id: <20200813120334.20928-5-s.reiter@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200813120334.20928-1-s.reiter@proxmox.com> References: <20200813120334.20928-1-s.reiter@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.313 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_NUMSUBJECT 0.5 Subject ends in numbers excluding current years RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH qemu-server 4/4] vzdump: log 100% percent in case $target is 0 X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2020 12:03:55 -0000 When $target is 0, that means we don't have to upload any data, in which case we're immediately done. Otherwise incremental backups with no changes display a really weird status: 0% (0.0 B of 0.0 B), duration 0, read: 0 B/s, write: 0 B/s when they're actually done already. Signed-off-by: Stefan Reiter --- PVE/VZDump/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm index 5edc62b..c919aa9 100644 --- a/PVE/VZDump/QemuServer.pm +++ b/PVE/VZDump/QemuServer.pm @@ -340,7 +340,7 @@ my $query_backup_status_loop = sub { $target = $total if !$has_query_bitmap; $transferred = $status->{transferred} || 0; $reused = $status->{reused}; - my $percent = $target ? int(($transferred * 100)/$target) : 0; + my $percent = $target ? int(($transferred * 100)/$target) : 100; my $zero = $status->{'zero-bytes'} || 0; die "got unexpected uuid\n" if !$status->{uuid} || ($status->{uuid} ne $job_uuid); -- 2.20.1