From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2997B608EF for ; Thu, 13 Aug 2020 14:04:25 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1E80E19E7E for ; Thu, 13 Aug 2020 14:03:55 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 931C319E52 for ; Thu, 13 Aug 2020 14:03:53 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 62D0D445EB for ; Thu, 13 Aug 2020 14:03:53 +0200 (CEST) From: Stefan Reiter To: pve-devel@lists.proxmox.com Date: Thu, 13 Aug 2020 14:03:30 +0200 Message-Id: <20200813120334.20928-1-s.reiter@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.058 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH 0/4] improve logging for dirty bitmap PBS backups X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2020 12:04:25 -0000 Makes the log output more useful for dirty bitmap backups and fixes some minor issues. A new QMP call is introduced to avoid shoving even more data in the possibly often called 'query-backup' and not having to do some hacky special casing for the first query iteration. The new QMP call is gated behind a new proxmox feature flag. The previous behaviour of having 'dirty' in 'query-backup' is not retained, this is fine and does not necessarily require a dependency bump: In case only one package is upgraded (either qemu-server or pve-qemu-kvm), no information about dirty bitmaps is printed, but the actual backup behaviour is unchanged. qemu: Stefan Reiter (1): PVE: add query-pbs-bitmap-info QMP call monitor/hmp-cmds.c | 28 +++++----- pve-backup.c | 119 +++++++++++++++++++++++++++++++------------ qapi/block-core.json | 62 ++++++++++++++++++++-- 3 files changed, 159 insertions(+), 50 deletions(-) qemu-server: Stefan Reiter (3): vzdump: improve logging output with dirty bitmaps vzdump: display actually uploaded chunks as 'write' speed vzdump: log 100% percent in case $target is 0 PVE/VZDump/QemuServer.pm | 72 +++++++++++++++++++++++++++++++--------- 1 file changed, 57 insertions(+), 15 deletions(-) -- 2.20.1