From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0D81E6092B for ; Thu, 13 Aug 2020 12:57:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F119719613 for ; Thu, 13 Aug 2020 12:57:39 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6CDCF19609 for ; Thu, 13 Aug 2020 12:57:39 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 36590445E0 for ; Thu, 13 Aug 2020 12:57:39 +0200 (CEST) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pve-devel@lists.proxmox.com Date: Thu, 13 Aug 2020 12:57:34 +0200 Message-Id: <20200813105734.3319823-1-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.033 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH manager] www: fix PBS edit typos X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2020 10:57:40 -0000 and unify encryption key generation strings. Signed-off-by: Fabian Grünbichler --- I don't think this check for isCreate makes sense, but maybe I am missing something? www/manager6/storage/PBSEdit.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/www/manager6/storage/PBSEdit.js b/www/manager6/storage/PBSEdit.js index dacebfdd..a418da0c 100644 --- a/www/manager6/storage/PBSEdit.js +++ b/www/manager6/storage/PBSEdit.js @@ -13,16 +13,13 @@ Ext.define('Proxmox.form.PBSEncryptionCheckbox', { blabel: (get) => { let v = get('value'); let original = get('originalValue'); - if (get('isCreate')) { - return gettext('Auto-generate a client encryption key, safed privately on cluster.'); - } if (original) { if (!v) { - return gettext('Warning: Existing encryption Key will be deleted!'); + return gettext('Warning: Existing encryption key will be deleted!'); } return gettext('Active'); } else { - return gettext('Auto-generate a client encryption key, safed privately on cluster filesystem'); + return gettext('Auto-generate a client encryption key, saved privately on PVE cluster.'); } }, }, -- 2.20.1