From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3410C69E03 for ; Mon, 10 Aug 2020 14:36:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 24CD1151C6 for ; Mon, 10 Aug 2020 14:36:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4E8051516E for ; Mon, 10 Aug 2020 14:36:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1C2304457B for ; Mon, 10 Aug 2020 14:36:02 +0200 (CEST) From: Fabian Ebner To: pve-devel@lists.proxmox.com Date: Mon, 10 Aug 2020 14:35:53 +0200 Message-Id: <20200810123557.22618-2-f.ebner@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200810123557.22618-1-f.ebner@proxmox.com> References: <20200810123557.22618-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.008 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [PATCH guest-common 2/6] job_status: read only after acquiring the lock X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Aug 2020 12:36:04 -0000 to get the current replication config and have the VM list and state object as recent as possible. Signed-off-by: Fabian Ebner --- PVE/ReplicationState.pm | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/PVE/ReplicationState.pm b/PVE/ReplicationState.pm index 057cae6..0c92778 100644 --- a/PVE/ReplicationState.pm +++ b/PVE/ReplicationState.pm @@ -234,13 +234,11 @@ sub job_status { my $jobs = {}; - my $stateobj = read_state(); - - my $cfg = PVE::ReplicationConfig->new(); - - my $vms = PVE::Cluster::get_vmlist(); - my $func = sub { + my $cfg = PVE::ReplicationConfig->new(); + my $stateobj = read_state(); + my $vms = PVE::Cluster::get_vmlist(); + foreach my $jobid (sort keys %{$cfg->{ids}}) { my $jobcfg = $cfg->{ids}->{$jobid}; my $vmid = $jobcfg->{guest}; -- 2.20.1