From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9FEAB696A4 for ; Thu, 6 Aug 2020 16:06:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8DAA91D9FE for ; Thu, 6 Aug 2020 16:06:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B3F951D9F3 for ; Thu, 6 Aug 2020 16:06:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 843CC4348C for ; Thu, 6 Aug 2020 16:06:13 +0200 (CEST) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pve-devel@lists.proxmox.com Date: Thu, 6 Aug 2020 16:06:05 +0200 Message-Id: <20200806140605.1027177-1-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.044 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH manager] vzdump: use configured tmpdir for PBS X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Aug 2020 14:06:45 -0000 instead of always using the default hard-coded one. otherwise, suspend mode container backups might run out of space even though the admin configured a big enough tmpdir. Signed-off-by: Fabian Grünbichler --- PVE/VZDump.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm index f80faeff..82976aa4 100644 --- a/PVE/VZDump.pm +++ b/PVE/VZDump.pm @@ -742,10 +742,10 @@ sub exec_backup_task { $task->{vmtype} = $vmtype; - if ($self->{opts}->{pbs}) { - $task->{tmpdir} = "/var/tmp/vzdumptmp$$"; #fixme - } elsif ($opts->{tmpdir}) { + if ($opts->{tmpdir}) { $task->{tmpdir} = "$opts->{tmpdir}/vzdumptmp$$"; + } elsif ($self->{opts}->{pbs}) { + $task->{tmpdir} = "/var/tmp/vzdumptmp$$"; #fixme } else { # dumpdir is posix? then use it as temporary dir my $info = get_mount_info($opts->{dumpdir}); -- 2.20.1