From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 570F069686 for ; Thu, 6 Aug 2020 13:14:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 531111C0CB for ; Thu, 6 Aug 2020 13:14:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 297D51C0BF for ; Thu, 6 Aug 2020 13:14:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id EB3BF437AB for ; Thu, 6 Aug 2020 13:14:02 +0200 (CEST) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pve-devel@lists.proxmox.com Date: Thu, 6 Aug 2020 13:13:49 +0200 Message-Id: <20200806111349.67063-2-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200806111349.67063-1-f.gruenbichler@proxmox.com> References: <20200806111349.67063-1-f.gruenbichler@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] [RFC qemu] allow backup of read-only block drives X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Aug 2020 11:14:07 -0000 this is needed for template backups with PBS until we have the backup equivalent of 'pbs-restore'. Signed-off-by: Fabian Grünbichler --- did some quick tests and didn't run into any issues - @Dietmar/@Stefan is that check needed for some non-obvious reason? .../0029-PVE-Backup-proxmox-backup-patches-for-qemu.patch | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/debian/patches/pve/0029-PVE-Backup-proxmox-backup-patches-for-qemu.patch b/debian/patches/pve/0029-PVE-Backup-proxmox-backup-patches-for-qemu.patch index 56161cc..7b4834a 100644 --- a/debian/patches/pve/0029-PVE-Backup-proxmox-backup-patches-for-qemu.patch +++ b/debian/patches/pve/0029-PVE-Backup-proxmox-backup-patches-for-qemu.patch @@ -527,7 +527,7 @@ new file mode 100644 index 0000000000..9ae89fb679 --- /dev/null +++ b/pve-backup.c -@@ -0,0 +1,959 @@ +@@ -0,0 +1,955 @@ +#include "proxmox-backup-client.h" +#include "vma.h" + @@ -1050,10 +1050,6 @@ index 0000000000..9ae89fb679 + blk = blk_by_name(*d); + if (blk) { + bs = blk_bs(blk); -+ if (bdrv_is_read_only(bs)) { -+ error_setg(task->errp, "Node '%s' is read only", *d); -+ goto err; -+ } + if (!bdrv_is_inserted(bs)) { + error_setg(task->errp, QERR_DEVICE_HAS_NO_MEDIUM, *d); + goto err; -- 2.20.1