From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C0FD667903 for ; Fri, 31 Jul 2020 19:17:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 06FCE1EF11 for ; Fri, 31 Jul 2020 19:17:10 +0200 (CEST) Received: from mailpro.odiso.net (mailpro.odiso.net [89.248.211.110]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 625DD1ED9E for ; Fri, 31 Jul 2020 19:16:56 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mailpro.odiso.net (Postfix) with ESMTP id AFAA1122E4EE; Fri, 31 Jul 2020 19:16:51 +0200 (CEST) Received: from mailpro.odiso.net ([127.0.0.1]) by localhost (mailpro.odiso.net [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id B8y38xe2g30x; Fri, 31 Jul 2020 19:16:51 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mailpro.odiso.net (Postfix) with ESMTP id 94AE8122E4EF; Fri, 31 Jul 2020 19:16:51 +0200 (CEST) X-Virus-Scanned: amavisd-new at mailpro.odiso.com Received: from mailpro.odiso.net ([127.0.0.1]) by localhost (mailpro.odiso.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id dOFjxg6Z1E77; Fri, 31 Jul 2020 19:16:51 +0200 (CEST) Received: from pve.fritz.box (unknown [213.211.148.86]) by mailpro.odiso.net (Postfix) with ESMTPSA id 6506E122E4EE; Fri, 31 Jul 2020 19:16:51 +0200 (CEST) From: Alexandre Derumier To: pve-devel@pve.proxmox.com Date: Fri, 31 Jul 2020 19:16:43 +0200 Message-Id: <20200731171643.13180-15-aderumier@odiso.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200731171643.13180-1-aderumier@odiso.com> References: <20200731171643.13180-1-aderumier@odiso.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [ipams.pm, vnets.pm, subnets.pm] Subject: [pve-devel] [PATCH v5 pve-network 14/14] vnets: add del_ip + rework add_ip/find_free_ip X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Jul 2020 17:17:41 -0000 Signed-off-by: Alexandre Derumier --- PVE/Network/SDN/Ipams.pm | 12 -------- PVE/Network/SDN/Subnets.pm | 60 ++++++++++++++++++++++++++++++++++++++ PVE/Network/SDN/Vnets.pm | 47 ++++++++++------------------- 3 files changed, 75 insertions(+), 44 deletions(-) diff --git a/PVE/Network/SDN/Ipams.pm b/PVE/Network/SDN/Ipams.pm index b634020..a979d46 100644 --- a/PVE/Network/SDN/Ipams.pm +++ b/PVE/Network/SDN/Ipams.pm @@ -64,17 +64,5 @@ sub complete_sdn_vnet { return $cmdname eq 'add' ? [] : [ PVE::Network::SDN::Vnets::sdn_ipa= ms_ids($cfg) ]; } =20 -sub next_free_ip { - my ($subnetid, $subnet) =3D @_; - - my $ipam_cfg =3D PVE::Network::SDN::Ipams::config(); - my $ipamid =3D $subnet->{ipam}; - return if !$ipamid; - - my $plugin_config =3D $ipam_cfg->{ids}->{$ipamid}; - my $plugin =3D PVE::Network::SDN::Ipams::Plugin->lookup($plugin_conf= ig->{type}); - my $ip =3D $plugin->add_next_freeip($plugin_config, $subnetid, $subn= et); - return $ip; -} 1; =20 diff --git a/PVE/Network/SDN/Subnets.pm b/PVE/Network/SDN/Subnets.pm index 454a9cf..3ce2d44 100644 --- a/PVE/Network/SDN/Subnets.pm +++ b/PVE/Network/SDN/Subnets.pm @@ -3,8 +3,10 @@ package PVE::Network::SDN::Subnets; use strict; use warnings; =20 +use Net::Subnet qw(subnet_matcher); use PVE::Cluster qw(cfs_read_file cfs_write_file cfs_lock_file); =20 +use PVE::Network::SDN::Ipams; use PVE::Network::SDN::SubnetPlugin; PVE::Network::SDN::SubnetPlugin->register(); PVE::Network::SDN::SubnetPlugin->init(); @@ -52,4 +54,62 @@ sub get_subnet { return $subnet; } =20 +sub find_ip_subnet { + my ($ip, $subnetslist) =3D @_; + + my $subnets_cfg =3D PVE::Network::SDN::Subnets::config(); + my @subnets =3D PVE::Tools::split_list($subnetslist) if $subnetslist= ; + + my $subnet =3D undef; + my $subnetid =3D undef; + + foreach my $s (@subnets) { + my $subnet_matcher =3D subnet_matcher($s); + next if !$subnet_matcher->($ip); + $subnetid =3D $s =3D~ s/\//-/r; + $subnet =3D $subnets_cfg->{ids}->{$subnetid}; + last; + } + die "can't find any subnet for ip $ip" if !$subnet; + + return ($subnetid, $subnet); +} + +sub next_free_ip { + my ($subnetid, $subnet) =3D @_; + + my $ipamid =3D $subnet->{ipam}; + return if !$ipamid; + + my $ipam_cfg =3D PVE::Network::SDN::Ipams::config(); + my $plugin_config =3D $ipam_cfg->{ids}->{$ipamid}; + my $plugin =3D PVE::Network::SDN::Ipams::Plugin->lookup($plugin_conf= ig->{type}); + my $ip =3D $plugin->add_next_freeip($plugin_config, $subnetid, $subn= et); + return $ip; +} + +sub add_ip { + my ($subnetid, $subnet, $ip) =3D @_; + + my $ipamid =3D $subnet->{ipam}; + return if !$ipamid; + + my $ipam_cfg =3D PVE::Network::SDN::Ipams::config(); + my $plugin_config =3D $ipam_cfg->{ids}->{$ipamid}; + my $plugin =3D PVE::Network::SDN::Ipams::Plugin->lookup($plugin_conf= ig->{type}); + $plugin->add_ip($plugin_config, $subnetid, $ip); +} + +sub del_ip { + my ($subnetid, $subnet, $ip) =3D @_; + + my $ipamid =3D $subnet->{ipam}; + return if !$ipamid; + + my $ipam_cfg =3D PVE::Network::SDN::Ipams::config(); + my $plugin_config =3D $ipam_cfg->{ids}->{$ipamid}; + my $plugin =3D PVE::Network::SDN::Ipams::Plugin->lookup($plugin_conf= ig->{type}); + $plugin->del_ip($plugin_config, $subnetid, $ip); +} + 1; diff --git a/PVE/Network/SDN/Vnets.pm b/PVE/Network/SDN/Vnets.pm index 07bc9ff..6ea3a9a 100644 --- a/PVE/Network/SDN/Vnets.pm +++ b/PVE/Network/SDN/Vnets.pm @@ -4,11 +4,8 @@ use strict; use warnings; =20 use PVE::Cluster qw(cfs_read_file cfs_write_file cfs_lock_file); -use PVE::Exception qw(raise_param_exc raise_perm_exc raise); use Net::IP; -use Net::Subnet qw(subnet_matcher); use PVE::Network::SDN::Subnets; -use PVE::Network::SDN::Ipams; =20 use PVE::Network::SDN::VnetPlugin; PVE::Network::SDN::VnetPlugin->register(); @@ -58,12 +55,10 @@ sub get_vnet { } =20 sub get_next_free_ip { - my ($vnetid, $ipversion) =3D @_; + my ($vnet, $ipversion) =3D @_; =20 $ipversion =3D 4 if !$ipversion; - my $vnets_cfg =3D PVE::Network::SDN::Vnets::config(); my $subnets_cfg =3D PVE::Network::SDN::Subnets::config(); - my $vnet =3D $vnets_cfg->{ids}->{$vnetid}; my @subnets =3D PVE::Tools::split_list($vnet->{subnets}) if $vnet->{= subnets}; my $ip =3D undef; my $subnet =3D undef; @@ -76,7 +71,7 @@ sub get_next_free_ip { $subnet =3D $subnets_cfg->{ids}->{$subnetid}; if ($subnet && $subnet->{ipam}) { eval { - $ip =3D PVE::Network::SDN::Ipams::next_free_ip($subnetid, $subnet); + $ip =3D PVE::Network::SDN::Subnets::next_free_ip($subnetid, $subnet); }; warn $@ if $@; } @@ -84,39 +79,27 @@ sub get_next_free_ip { } die "can't find any free ip" if !$ip && $subnetcount > 0; =20 - $subnet->{freeip} =3D $ip; - return $subnet; + return $ip; } =20 sub add_ip { - my ($vnetid, $cidr, $name) =3D @_; + my ($vnet, $cidr, $name) =3D @_; =20 - my $vnets_cfg =3D PVE::Network::SDN::Vnets::config(); - my $subnets_cfg =3D PVE::Network::SDN::Subnets::config(); - my $vnet =3D $vnets_cfg->{ids}->{$vnetid}; - my @subnets =3D PVE::Tools::split_list($vnet->{subnets}) if $vnet->{= subnets}; - my $subnet =3D undef; - my $subnetid =3D undef; my ($ip, $mask) =3D split(/\//, $cidr); + my ($subnetid, $subnet) =3D PVE::Network::SDN::Subnets::find_ip_subn= et($ip, $vnet->{subnets}); + return if !$subnet->{ipam}; =20 - foreach my $s (@subnets) { - my $subnet_matcher =3D subnet_matcher($s); - next if !$subnet_matcher->($ip); - $subnetid =3D $s =3D~ s/\//-/r; - $subnet =3D $subnets_cfg->{ids}->{$subnetid}; - last; - } - raise_param_exc({'ip' =3D> "can't find any subnet attached to vnet = $vnetid for ip $ip"}) if !$subnet; + PVE::Network::SDN::Subnets::add_ip($subnetid, $subnet, $ip); +} + +sub del_ip { + my ($vnet, $cidr) =3D @_; + + my ($ip, $mask) =3D split(/\//, $cidr); + my ($subnetid, $subnet) =3D PVE::Network::SDN::Subnets::find_ip_subn= et($ip, $vnet->{subnets}); return if !$subnet->{ipam}; =20 - eval { - my $ipamid =3D $subnet->{ipam}; - my $ipam_cfg =3D PVE::Network::SDN::Ipams::config(); - my $plugin_config =3D $ipam_cfg->{ids}->{$ipamid}; - my $plugin =3D PVE::Network::SDN::Ipams::Plugin->lookup($plugin_config-= >{type}); - $plugin->add_ip($plugin_config, $subnetid, $ip); - }; - raise_param_exc({'ip' =3D> $@}) if $@; + PVE::Network::SDN::Subnets::del_ip($subnetid, $subnet, $ip); } =20 1; --=20 2.20.1