From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3B66E66769 for ; Mon, 27 Jul 2020 10:56:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2D4241AA6A for ; Mon, 27 Jul 2020 10:55:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 633E21AA60 for ; Mon, 27 Jul 2020 10:55:40 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2959043212 for ; Mon, 27 Jul 2020 10:55:40 +0200 (CEST) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pve-devel@lists.proxmox.com Date: Mon, 27 Jul 2020 10:55:35 +0200 Message-Id: <20200727085535.2621695-1-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.045 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH manager] fix #2890: also detect & renew DNS-only ACME certs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2020 08:56:12 -0000 this call site was apparently missed when we refactored the node config / ACME interaction. Suggested/Reported-by: Frédéric Bourqui Signed-off-by: Fabian Grünbichler --- bin/pveupdate | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/bin/pveupdate b/bin/pveupdate index 56d5d718..99b52fe9 100755 --- a/bin/pveupdate +++ b/bin/pveupdate @@ -60,7 +60,8 @@ if (my $err = $@) { eval { my $node_config = PVE::NodeConfig::load_config($nodename); - if ($node_config && $node_config->{acme}) { + my $acme_node_config = PVE::NodeConfig::get_acme_conf($node_config); + if ($acme_node_config && $acme_node_config->{domains}) { my $cert = PVE::CertHelpers::cert_path_prefix($nodename).".pem"; if (-e $cert) { if (PVE::Certificate::check_expiry($cert, time() + 30*24*60*60)) { -- 2.20.1