From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3F40962F1F for ; Tue, 14 Jul 2020 13:51:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 05F4C267C7 for ; Tue, 14 Jul 2020 13:51:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 100F02677E for ; Tue, 14 Jul 2020 13:51:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CF60542BD3 for ; Tue, 14 Jul 2020 13:51:12 +0200 (CEST) From: Dominik Csapak To: pve-devel@lists.proxmox.com Date: Tue, 14 Jul 2020 13:51:06 +0200 Message-Id: <20200714115106.30195-5-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200714115106.30195-1-d.csapak@proxmox.com> References: <20200714115106.30195-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.033 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pve-devel] [PATCH xtermjs v2 4/4] ui: prevent accidental closing of terminal window X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2020 11:51:44 -0000 this prevents closing the window e.g. when pressing ctrl+w most browsers have a function to block a website from doing that, so users that do not want that, simply have to click that option also, the message will (at least in chrome) not be displayed, instead a fixed message will appear Signed-off-by: Dominik Csapak --- new in v2, please interpret as RFC src/www/main.js | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/www/main.js b/src/www/main.js index 55834eb..43fe656 100644 --- a/src/www/main.js +++ b/src/www/main.js @@ -143,7 +143,7 @@ function createTerminal() { socket.onopen = runTerminal; socket.onclose = tryReconnect; socket.onerror = tryReconnect; - window.onbeforeunload = stopTerminal; + window.onbeforeunload = windowUnload; updateState(states.connecting); }, failure: function(msg) { @@ -303,6 +303,17 @@ function clearEvents() { term.onData(() => {}); } +function windowUnload(e) { + let message = "Are you sure you want to leave this page?"; + + e = e || window.event; + if (e) { + e.returnValue = message; + } + + return message; +} + function stopTerminal(event) { event = event || {}; clearEvents(); -- 2.20.1