From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <o.bektas@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 43E79626B9
 for <pve-devel@pve.proxmox.com>; Mon, 13 Jul 2020 13:16:51 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 3C3C41A29D
 for <pve-devel@pve.proxmox.com>; Mon, 13 Jul 2020 13:16:51 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id C4A601A293
 for <pve-devel@pve.proxmox.com>; Mon, 13 Jul 2020 13:16:50 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 831754327D
 for <pve-devel@pve.proxmox.com>; Mon, 13 Jul 2020 13:16:50 +0200 (CEST)
Date: Mon, 13 Jul 2020 13:16:48 +0200
From: Oguz Bektas <o.bektas@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: PVE development discussion <pve-devel@pve.proxmox.com>
Message-ID: <20200713111648.GA16309@gaia.proxmox.com>
Mail-Followup-To: Oguz Bektas <o.bektas@proxmox.com>,
 Thomas Lamprecht <t.lamprecht@proxmox.com>,
 PVE development discussion <pve-devel@pve.proxmox.com>
References: <20200702101023.237367-1-o.bektas@proxmox.com>
 <4a8fa320-eea0-8749-9148-dc6b7e5e1fbb@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4a8fa320-eea0-8749-9148-dc6b7e5e1fbb@proxmox.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-SPAM-LEVEL: Spam detection results:  0
 AWL 1.347 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] applied: [PATCH v3 container] fix #2820: don't
 hotplug over existing mpX
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 13 Jul 2020 11:16:51 -0000

On Mon, Jul 13, 2020 at 01:00:55PM +0200, Thomas Lamprecht wrote:
> On 02.07.20 12:10, Oguz Bektas wrote:
> > check if the given mpX already exists in the config.  if it does, then
> > skip hotplugging and write the changes to [pve:pending] for the next
> > reboot of CT.
> > 
> > after rebooting the CT, the preexisting mpX will be added as unused and
> > the mpX will be mounted.
> > 
> > Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> > ---
> >  src/PVE/LXC/Config.pm | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> >
> 
> applied, thanks! Maybe we want the GUI "Add MP" to avoid pre selecting a MP id
> which is pending deletions? At least if others are still free?

yes, makes sense. i'll look into that