From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id A69EA1FF180 for ; Fri, 1 Aug 2025 13:18:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7BD8F1753C; Fri, 1 Aug 2025 13:19:50 +0200 (CEST) Message-ID: <2014f691-aa28-4ab4-91c1-48c1f68d8a54@proxmox.com> Date: Fri, 1 Aug 2025 13:19:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Fiona Ebner , Stefan Hanreich References: <20250801092701.48332-1-f.ebner@proxmox.com> <0f6db1c9-a1bd-4ac3-9836-79ceac6b4eec@proxmox.com> Content-Language: en-US From: Thomas Lamprecht In-Reply-To: <0f6db1c9-a1bd-4ac3-9836-79ceac6b4eec@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1754047173394 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.180 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] ui: sdn: ipam/dhcp: allow sorting by guest ID X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 01.08.25 um 11:45 schrieb Fiona Ebner: > Am 01.08.25 um 11:27 AM schrieb Fiona Ebner: >> Previously, sorting would not apply to the leaves of the tree. >> >> Signed-off-by: Fiona Ebner >> --- >> www/manager6/tree/DhcpTree.js | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/www/manager6/tree/DhcpTree.js b/www/manager6/tree/DhcpTree.js >> index 0088d708..40eb40bf 100644 >> --- a/www/manager6/tree/DhcpTree.js >> +++ b/www/manager6/tree/DhcpTree.js >> @@ -75,6 +75,7 @@ Ext.define('PVE.sdn.DhcpTree', { >> vnets[element.vnet].children.push(subnet); >> } >> >> + element.name = element.vmid; // for sorting >> element.type = 'mapping'; >> element.iconCls = 'x-tree-icon-none'; >> subnets[element.subnet].children.push(element); > > Just noticed that this doesn't sort numerically, because the returned > values are strings. Should I fix it up here by using parseInt() or > should we change the API endpoint to return integers already? A dedicated VMID return property, i.e. that always will just contain the VMID (not like "id" from /cluster/resources/ which depends on the resource type) should indeed always be an integer, so changing the type in the API seems alright to me. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel