From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <f.ebner@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8B39190FD2 for <pve-devel@lists.proxmox.com>; Fri, 26 Jan 2024 12:15:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6404F34569 for <pve-devel@lists.proxmox.com>; Fri, 26 Jan 2024 12:15:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Fri, 26 Jan 2024 12:15:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A5D45492DB for <pve-devel@lists.proxmox.com>; Fri, 26 Jan 2024 12:15:04 +0100 (CET) Message-ID: <200f1517-290f-4912-8345-de3f9bc9be9a@proxmox.com> Date: Fri, 26 Jan 2024 12:15:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Friedrich Weber <f.weber@proxmox.com> References: <20240111150332.733635-1-f.weber@proxmox.com> <20240111150332.733635-3-f.weber@proxmox.com> From: Fiona Ebner <f.ebner@proxmox.com> In-Reply-To: <20240111150332.733635-3-f.weber@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.074 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH storage 2/2] fix #4997: lvm: set "activation skip" flag for newly created LVs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Fri, 26 Jan 2024 11:15:36 -0000 Am 11.01.24 um 16:03 schrieb Friedrich Weber: > Activating an LV creates a device-mapper device. In a cluster with a > shared LVM VG (e.g. on top of iSCSI) where an LV is active on nodes 1 > and 2, deleting the LV on node 1 will not clean up the device-mapper > device on node 2. If an LV with the same name is recreated later, the > leftover device-mapper device will cause activation of that LV on node > 2 to fail with: > >> device-mapper: create ioctl on [...] failed: Device or resource busy > > By default, LVM autoactivates all discovered LVs after boot, thus > creating device-mapper device for all discovered LVs. As a result, > certain combinations of guest removal (and thus LV removals) and node > reboots can cause guest creation or VM live migration (which both > entail LV activation) to fail with the above error message, see [1]. > > To avoid this issue in the future, adjust the LVM plugin to create new > LVs with the "activation skip" flag. LVs with that flag are not > activated unless `-K` is passed to the activation command. Consequently, > new LVs will not be autoactivated after boot anymore, and removing LVs > will not leave behind device-mapper devices on other nodes anymore. > > The LVM plugin is still able to activate LVs, as it already passes > `-K` to all activation commands. > > Note that the flag is only set for newly created LVs, so LVs created > before this patch can still trigger #4997. To avoid this, users can > manually set the "activation skip" flag on existing LVs. > > [1] https://bugzilla.proxmox.com/show_bug.cgi?id=4997 > > Suggested-by: Fabian Grünbichler <f.gruenbichler@proxmox.com> > Signed-off-by: Friedrich Weber <f.weber@proxmox.com> Reviewed-by: Fiona Ebner <f.ebner@proxmox.com> > --- > > Notes: > Should only be applied close to the next major release, see cover > letter. > > src/PVE/Storage/LVMPlugin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >