From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4FEE4F5DC for ; Fri, 21 Jul 2023 16:11:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 29A9430078 for ; Fri, 21 Jul 2023 16:10:58 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 21 Jul 2023 16:10:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4329942698 for ; Fri, 21 Jul 2023 16:10:56 +0200 (CEST) Message-ID: <1f934670-d29f-4d84-a72f-72b8232db8d8@proxmox.com> Date: Fri, 21 Jul 2023 16:10:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: Proxmox VE development discussion , Dominik Csapak , Noel Ullreich References: <20230626124136.33973-1-n.ullreich@proxmox.com> <20230626124136.33973-2-n.ullreich@proxmox.com> <687011da-f90f-f3b7-b8cb-44be27762191@proxmox.com> From: Thomas Lamprecht In-Reply-To: <687011da-f90f-f3b7-b8cb-44be27762191@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.076 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [github.io] Subject: Re: [pve-devel] [PATCH pve-docs v8 1/1] update the PCI(e) docs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Jul 2023 14:11:28 -0000 On 20/07/2023 10:09, Dominik Csapak wrote: > On 6/26/23 14:41, Noel Ullreich wrote: >> @@ -75,13 +93,15 @@ to the xref:sysboot_edit_kernel_cmdline[kernel commandline]. >>   .Kernel Modules >>     You have to make sure the following modules are loaded. This can be achieved by >> -adding them to `'/etc/modules'' >> +adding them to `'/etc/modules''. In kernels newer than 6.2 ({pve} 8 and onward) >> +the 'vfio_virqfd' module is part of the 'vfio' module, therefore loading >> +'vfio_virqfd' in {pve} 8 and newer is not necessary. >>     ---- >>    vfio >>    vfio_iommu_type1 >>    vfio_pci >> - vfio_virqfd >> + vfio_virqfd #not needed if on kernel 6.2 or newer >>   ---- > > i'd add some comment (does such a thing exists in asciidoc?) or something > so that we can remove that part with e.g. pve 9.x > since thats only relevant as long as we're supporting 7.x yes, can use // at start of line in asciidoc for comments, like: // TODO: adapt/remove/... with Proxmox VE 9 You naturally need to position it outside of the code block though, else it's verbatim text. >>   # qm set VMID -hostpci0 02:00,device-id=0x10f6,sub-vendor-id=0x0000 >>   ---- >>   - >> -Other considerations >> -^^^^^^^^^^^^^^^^^^^^ >> - >> -When passing through a GPU, the best compatibility is reached when using >> -'q35' as machine type, 'OVMF' ('EFI' for VMs) instead of SeaBIOS and PCIe >> -instead of PCI. Note that if you want to use 'OVMF' for GPU passthrough, the >> -GPU needs to have an EFI capable ROM, otherwise use SeaBIOS instead. >> - >>   SR-IOV >>   ~~~~~~ >>   -Another variant for passing through PCI(e) devices, is to use the hardware >> +Another variant for passing through PCI(e) devices is to use the hardware >>   virtualization features of your devices, if available. >>   +{{Note | To use SR-IOV, platform support is especially important. It may be necessary >> +to enable this feature in the BIOS/UEFI first, or to use a specific PCI(e) port >> +for it to work. In doubt, consult the manual of the platform or contact its >> +vendor.}} > > this syntax does not work here with the html nor the pdf renderer, maybe > some bad copy&paste ? Yeah, this looks like mediawiki syntax,rather use the Asciidoc admonition syntax, in a new paragraph: NOTE: To use SR-IOV, platform support is especially important. ... https://asciidoc-py.github.io/userguide.html#X28