From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AD62E92D59 for ; Thu, 23 Mar 2023 15:09:45 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F01022D013 for ; Thu, 23 Mar 2023 15:09:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 23 Mar 2023 15:09:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 247A3465D5 for ; Thu, 23 Mar 2023 15:09:09 +0100 (CET) Message-ID: <1eae62a4-231a-6cd0-6cfe-43f7c6978549@proxmox.com> Date: Thu, 23 Mar 2023 15:09:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 To: Proxmox VE development discussion , Dominik Csapak References: <20230323131430.3185211-1-d.csapak@proxmox.com> <20230323131430.3185211-2-d.csapak@proxmox.com> Content-Language: en-US From: Friedrich Weber In-Reply-To: <20230323131430.3185211-2-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.369 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH access-control 1/1] fix #4609: allow valid DN in ldap/ad realm config X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2023 14:09:45 -0000 Tested-by: Friedrich Weber Tested the following: * PVE 7.3: setup LDAP realms realm #1 with `base_dn ou=Foo- und Bar,dc=example,dc=com` realm #2 with `base_dn ou=Users,dc=example,dc=com` both work, i.e., sync is possible and users can log in * Update to 7.4: realm #1: users cannot login ("value does not match the regex pattern") realm #2: still works * With this patch: realm #1: login works again realm #2: still works On 23/03/2023 14:14, Dominik Csapak wrote: > we previously added support for ',' in the dns attribute by allowing a > quoted format. the regex was sadly too restrictive: