From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 63AEF747A4 for ; Wed, 2 Jun 2021 10:30:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 51BCB87FF for ; Wed, 2 Jun 2021 10:29:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3B84E87F0 for ; Wed, 2 Jun 2021 10:29:43 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0DAE3466E6 for ; Wed, 2 Jun 2021 10:29:43 +0200 (CEST) To: pve-devel@lists.proxmox.com, Aaron Lauterer References: <20210601161025.32024-1-a.lauterer@proxmox.com> <20210601161025.32024-2-a.lauterer@proxmox.com> From: Fabian Ebner Message-ID: <1e42feae-5362-1efb-a8d2-5ee425f17d67@proxmox.com> Date: Wed, 2 Jun 2021 10:29:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210601161025.32024-2-a.lauterer@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.294 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.613 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [storage.pm] Subject: Re: [pve-devel] [RFC storage 1/7] storage: expose find_free_diskname X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jun 2021 08:30:17 -0000 Am 01.06.21 um 18:10 schrieb Aaron Lauterer: > Signed-off-by: Aaron Lauterer > --- > PVE/Storage.pm | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/PVE/Storage.pm b/PVE/Storage.pm > index aa36bad..93d09ce 100755 > --- a/PVE/Storage.pm > +++ b/PVE/Storage.pm > @@ -201,6 +201,14 @@ sub storage_can_replicate { > return $plugin->storage_can_replicate($scfg, $storeid, $format); > } > > +sub find_free_diskname { > + my ($cfg, $storeid, $vmid, $fmt, $add_fmt_suffix) = @_; Nit: Ideally, the $add_fmt_suffix should be decided by the plugin, as an outside caller cannot know what a plugin wants/expects. Don't know if that's easy to do the way things are though. > + > + my $scfg = storage_config($cfg, $storeid); > + my $plugin = PVE::Storage::Plugin->lookup($scfg->{type}); > + return $plugin->find_free_diskname($storeid, $scfg, $vmid, $fmt, $add_fmt_suffix); > +} > + > sub storage_ids { > my ($cfg) = @_; > >