From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9C7BB9F99 for ; Thu, 7 Sep 2023 11:07:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 78A6140EF for ; Thu, 7 Sep 2023 11:07:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 7 Sep 2023 11:07:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id ED8C942E75 for ; Thu, 7 Sep 2023 11:07:19 +0200 (CEST) Message-ID: <1e15b427-485d-4530-ae38-76cdbf757742@proxmox.com> Date: Thu, 7 Sep 2023 11:07:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Thomas Lamprecht , Proxmox VE development discussion References: <20230905085331.541541-1-m.sandoval@proxmox.com> <75631e85-0440-46c7-a359-ab0d9a80209a@proxmox.com> From: Maximiliano Sandoval In-Reply-To: <75631e85-0440-46c7-a359-ab0d9a80209a@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy HTML_MESSAGE 0.001 HTML included in message KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [pve-devel] applied: [PATCH manager] fix #4808: ceph: use setting names with underscores X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Sep 2023 09:07:52 -0000 > Also, did you checked for other such occurrences in our API? I found another place where they are used in pve-manager's PVE/API2/Ceph module. I will send a patch, but most interesting is that we set     $cfg->{global}->{'osd pg bits'} = $param->{pg_bits};     $cfg->{global}->{'osd pgp bits'} = $param->{pg_bits}; and expose them in the API. This setting is documented in the Pacific docs [1], but not in the Quincy docs [2]. I could not find much info about this. It is not mentioned on the Quincy release notes [3] as far as I can tell. [1] https://docs.ceph.com/en/pacific/rados/configuration/pool-pg-config-ref/ [2] https://docs.ceph.com/en/quincy/rados/configuration/pool-pg-config-ref/ [3] https://docs.ceph.com/en/latest/releases/quincy/#v17-2-0-quincy