From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <d.csapak@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id F2C968ABDE
 for <pve-devel@lists.proxmox.com>; Fri, 21 Oct 2022 14:45:39 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id D63E82202A
 for <pve-devel@lists.proxmox.com>; Fri, 21 Oct 2022 14:45:09 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pve-devel@lists.proxmox.com>; Fri, 21 Oct 2022 14:45:08 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B8DB044B10;
 Fri, 21 Oct 2022 14:45:08 +0200 (CEST)
Message-ID: <1dc02892-cecc-7758-d0dc-3836bc6f55ee@proxmox.com>
Date: Fri, 21 Oct 2022 14:45:08 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:106.0) Gecko/20100101
 Thunderbird/106.0
Content-Language: en-US
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Markus Frank <m.frank@proxmox.com>
References: <20221020111443.158234-1-m.frank@proxmox.com>
From: Dominik Csapak <d.csapak@proxmox.com>
In-Reply-To: <20221020111443.158234-1-m.frank@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.068 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.001 Looks like a legit reply (A)
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH qemu-server v2 1/5] enable clipboard
 parameter in vga_fmt
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Fri, 21 Oct 2022 12:45:40 -0000

High level comments after playing around with it:

is it really not possible to have c&p working for both novnc and spice?

AFAICS the qemu-vdagent chardev replaces spicevmc, but that means one
can either have c&p in spice OR vnc, but never both at the same time
(shame really, since i don't think it would be much work.. but of course
i'm not very familiar with the qemu code for this)

in that case, i would either:

* not allow to enable this when SPICE is selected as a gpu
or
* make it *very* clear in the ui and documentation that both
   simultaneously don't work (e.g. put a yellow warning under the checkbox)

also, it should be much clearer in the GUI  (and option documentation) that
it's necessary to install the spice client in the guest for this to work.
As it is, we'd get many confused users asking 'why doesn't it work' just
because they don't know it only works with the spice guest tools + a
graphical ui in the vm

A smaller (but important) thing is that i'd like to see a new cfg2cmd test
for new options. it should be enough to enable that option for an existing
test and adapt the output (or make a new test case).