From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5AF4F739E9 for ; Fri, 18 Jun 2021 18:19:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 49379A9AD for ; Fri, 18 Jun 2021 18:18:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2E35CA99C for ; Fri, 18 Jun 2021 18:18:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E780E44232 for ; Fri, 18 Jun 2021 18:18:33 +0200 (CEST) Message-ID: <1cf7d618-6cbe-0d25-49e9-fd3cfb1b0362@proxmox.com> Date: Fri, 18 Jun 2021 18:18:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox VE development discussion , Oguz Bektas References: <20210617105201.804786-1-o.bektas@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210617105201.804786-1-o.bektas@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.774 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [setup.pm, lxc.pm, base.pm] Subject: [pve-devel] applied: [PATCH v5 container 0/4] post_clone_hook for containers X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2021 16:19:05 -0000 On 17.06.21 12:51, Oguz Bektas wrote: > add post clone hook, and fix #3443 to clear machine-id for cloned > containers > > > v4->v5: > * split patches for easy review/backport > * also lock when moving config to target node > * move create_and_lock_config outside the eval, this should be checked > before the other ones > > > Oguz Bektas (4): > setup: add post_clone_hook for containers > clone_vm: improve config locking > run post_clone_hook in clone_vm API > clone_vm: fix minor typo in error message > > src/PVE/API2/LXC.pm | 55 +++++++++++++++++++++++++++------------ > src/PVE/LXC/Setup.pm | 12 +++++++++ > src/PVE/LXC/Setup/Base.pm | 31 ++++++++++++++++++++++ > 3 files changed, 81 insertions(+), 17 deletions(-) > applied with Fabians followups (thanks for those!), but it is still buggy then, i.e., - LXC::Setup post_clone_hook was just completely off - if a (non-systemd) CT without any /etc/machine-id present gets cloned it suddenly gets an empty one? so pushed out two followups to fix that mess...