From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E25221FF389 for ; Wed, 5 Jun 2024 10:51:13 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D43D11EA82; Wed, 5 Jun 2024 10:51:43 +0200 (CEST) Message-ID: <1cef7702-7fdc-477f-b8f9-b8ce8fe6c28b@proxmox.com> Date: Wed, 5 Jun 2024 10:51:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Fiona Ebner , Proxmox VE development discussion References: <20240419124556.3334691-1-d.csapak@proxmox.com> <20240419124556.3334691-12-d.csapak@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.021 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH qemu-server v3 07/10] pci: set 'enable-migration' to on for live-migration marked mapped devices X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 5/31/24 14:56, Fiona Ebner wrote: > Am 19.04.24 um 14:45 schrieb Dominik Csapak: >> the default is 'auto', but for those which are marked as capable for >> live migration, we want to explicitly enable that, so we get an early >> error on start if the driver does not support that. >> >> Signed-off-by: Dominik Csapak >> --- >> PVE/QemuServer/PCI.pm | 9 ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/PVE/QemuServer/PCI.pm b/PVE/QemuServer/PCI.pm >> index 6ba43ee8..df2ea3eb 100644 >> --- a/PVE/QemuServer/PCI.pm >> +++ b/PVE/QemuServer/PCI.pm >> @@ -435,8 +435,11 @@ sub parse_hostpci { >> my $devices = PVE::Mapping::PCI::get_node_mapping($config, $mapping, $node); >> die "PCI device mapping not found for '$mapping'\n" if !$devices || !scalar($devices->@*); >> >> + my $cfg = $config->{ids}->{$mapping}; >> + $res->{'live-migration-capable'} = 1 if $cfg->{'live-migration-capable'}; >> + >> for my $device ($devices->@*) { >> - eval { PVE::Mapping::PCI::assert_valid($mapping, $device, $config->{ids}->{$mapping}) }; >> + eval { PVE::Mapping::PCI::assert_valid($mapping, $device, $cfg) }; > > > This hunk belongs in patch 03/10) why though? in 03/10 i adapt to the new $cfg parameter to check the mdev parameter, and here i refactor it because we have to access it twice (for the live-migration-capable flag) i mean i can pull it out into the $cfg before, but the the live-migration part does IMO not belong in 03/10 > >> die "PCI device mapping invalid (hardware probably changed): $@\n" if $@; >> push $alternatives->@*, [split(/;/, $device->{path})]; >> } >> @@ -635,6 +638,10 @@ sub print_hostpci_devices { >> $devicestr .= ",host=$pcidevice->{id}"; >> } >> >> + if ($d->{'live-migration-capable'}) { >> + $devicestr .= ",enable-migration=on" >> + } >> + >> my $mf_addr = $multifunction ? ".$j" : ''; >> $devicestr .= ",id=${id}${mf_addr}${pciaddr}${mf_addr}"; >> _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel