From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EDA4661A2D for ; Thu, 22 Oct 2020 08:48:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E14E01D009 for ; Thu, 22 Oct 2020 08:48:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C94F51CFFD for ; Thu, 22 Oct 2020 08:48:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6039245ED5 for ; Thu, 22 Oct 2020 08:48:00 +0200 (CEST) To: Proxmox VE development discussion , Stefan Reiter References: <20201021090025.13321-1-s.reiter@proxmox.com> From: Thomas Lamprecht Message-ID: <1c7ca566-adbf-b706-a439-84adba049b32@proxmox.com> Date: Thu, 22 Oct 2020 08:47:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:82.0) Gecko/20100101 Thunderbird/82.0 MIME-Version: 1.0 In-Reply-To: <20201021090025.13321-1-s.reiter@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.127 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: [pve-devel] applied: [PATCH qemu-server] bootorder: don't print empty 'order=' property X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Oct 2020 06:48:32 -0000 On 21.10.20 11:00, Stefan Reiter wrote: > Specifying 'boot: order=3D' was intended to be used for an empty bootor= der > (i.e. no boot devices), but as it turns out our format parser doesn't > like empty '-list' properties if they are nested in a subformat. >=20 > Fixing this in JSONSchema sounds like a risky move, so instead just > write 'boot: ' (without 'order=3D') to indicate an empty bootorder. The= > rest of the code handles it just fine, as this was valid before too. >=20 > Incidentally also fixes a bug where you couldn't create a new VM withou= t > any disks if no explicit 'boot' property was specified (i.e. a simple > 'qm create 100' without any parameters would fail). >=20 > Reported-by: Dominic J=C3=A4ger > Signed-off-by: Stefan Reiter > --- > PVE/QemuServer.pm | 1 + > 1 file changed, 1 insertion(+) >=20 > applied, thanks!