From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 669B9AA3B; Wed, 27 Apr 2022 19:43:39 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5EC4529CF6; Wed, 27 Apr 2022 19:43:39 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 659A129CEC; Wed, 27 Apr 2022 19:43:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 38A4A42F11; Wed, 27 Apr 2022 19:43:38 +0200 (CEST) Message-ID: <1c6f3e5d-8079-538d-1035-67940df3fffc@proxmox.com> Date: Wed, 27 Apr 2022 19:43:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:100.0) Gecko/20100101 Thunderbird/100.0 Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20220426101401.3216096-1-d.csapak@proxmox.com> Cc: Proxmox Backup Server development discussion From: Thomas Lamprecht In-Reply-To: <20220426101401.3216096-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] partiall-applied: [PATCH proxmox-backup/common/storage/wt v2] improve file-restore timeout behaviour X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Apr 2022 17:43:39 -0000 On 26.04.22 12:13, Dominik Csapak wrote: > this series improves the behaviour of the file-restore when some mount > operations take longer than the 30 second pveproxy timeout, and improves > the startup speed of the restore vm > > we do this by moving the disk init into the background of the daemon > startup, while the hyper server is starting, and by adding a timeout > option to the file-restore binary. > > to be able to report the error back to the gui, we return a > 'SERVICE_UNAVAILABLE' error in the timeout case, and the gui tries > again (up to 10 times). > > backup patches 2,3 could be applied independently, as they even make > sense withouth the rest > > pve-storage depends on a new pve-common&file-restore > > widget-toolkit makes only sense with the other patches, but is > designed to not change behaviour with the old api > > alternatively i could drop the 'json-error' parameter and do it > always, or when timeout it set. > > changes from v1: > * rebased on master > * moved the json-error and timeout directly into pve-common (hardcoded) > since there is only one usage of that function > > proxmox-backup: > > Dominik Csapak (5): > restore-daemon: start disk initialization in parallel to the api > restore-daemon: put blocking code into 'block_in_place' > restore-daemon: avoid auto-mounting zpools > file-restore: factor out 'list_files' > file-restore: add 'timeout' and 'json-error' parameter > > proxmox-file-restore/src/main.rs | 206 ++++++++++++------ > proxmox-restore-daemon/src/main.rs | 31 ++- > .../src/proxmox_restore_daemon/api.rs | 12 +- > .../src/proxmox_restore_daemon/disk.rs | 20 +- > 4 files changed, 166 insertions(+), 103 deletions(-) applied above PBS ones. fwiw, I'd appreciate getting PBS related patches also on the PBS list, though I somehow deleted them when I did not find them there ^^. And just for clarity, there's no need to always CC the full series if it's a pve/pbs mixed one.