From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 053A365FDC for ; Wed, 9 Mar 2022 13:32:38 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F1A521D46D for ; Wed, 9 Mar 2022 13:32:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id DDB411D460 for ; Wed, 9 Mar 2022 13:32:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AF37E42053 for ; Wed, 9 Mar 2022 13:32:36 +0100 (CET) Message-ID: <1c689b6a-3500-1c0a-3855-b7dedbd124b5@proxmox.com> Date: Wed, 9 Mar 2022 13:32:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Content-Language: en-US To: pve-devel@lists.proxmox.com, m.heiserer@proxmox.com References: <20220304115218.665615-1-m.heiserer@proxmox.com> <20220304115218.665615-2-m.heiserer@proxmox.com> From: Fabian Ebner In-Reply-To: <20220304115218.665615-2-m.heiserer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.123 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager 2/3] GUI: Utils: Helpers for backup type and icon X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2022 12:32:38 -0000 Am 04.03.22 um 12:52 schrieb Matthias Heiserer: > Signed-off-by: Matthias Heiserer > --- > www/manager6/Utils.js | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js > index aafe359a..650eeee9 100644 > --- a/www/manager6/Utils.js > +++ b/www/manager6/Utils.js > @@ -1803,6 +1803,26 @@ Ext.define('PVE.Utils', { > > return undefined; > }, > + > + get_type_icon_cls: function(volid, format) { This name is too generic if it doesn't mention 'backup'. > + var cls = ''; > + if (PVE.Utils.volume_is_qemu_backup(volid, format)) { > + cls = 'fa-desktop'; > + } else if (PVE.Utils.volume_is_lxc_backup(volid, format)) { > + cls = 'fa-cube'; > + } > + return cls; > + }, > + > + get_backup_type: function(volid, format) { > + if (PVE.Utils.volume_is_qemu_backup(volid, format)) { > + return 'qemu'; > + } else if (PVE.Utils.volume_is_lxc_backup(volid, format)) { > + return 'lxc'; > + } else { > + throw 'Unknown backup type'; > + } > + }, > }, > > singleton: true,